Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51266

Review incorrect phpunit_util uses and replace them by correct advanced_testcase extra methods

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.7, 2.9.1, 3.0
    • Fix Version/s: 2.8.9, 2.9.3
    • Component/s: Unit tests
    • Labels:

      Description

      While reviewing MDL-46239 it was detected that various "low level" phpunit_util::xxxxx() methods were being used in testcases.

      Looking globally lots of those uses were found, for example:

      $ ag 'reset_debugging|get_debugging_messages' | wc -l
      72
      

      This issue is about to replace all them by the higher level extra function available @ advanced_testcase. Reference:

      https://docs.moodle.org/dev/PHPUnit_integration#Extra_methods

      Ciao

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                rajeshtaneja Rajesh Taneja
                Reporter:
                stronk7 Eloy Lafuente (stronk7)
                Peer reviewer:
                Simey Lameze
                Integrator:
                Eloy Lafuente (stronk7)
                Tester:
                Eloy Lafuente (stronk7)
                Participants:
                Component watchers:
                Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Nov/15