Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51315

Do not display "Reset table preferences" on table without preferences

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. View a table that has either persistent preferences or collapsible columns, e.g. the assignment grading table
      2. If there is no 'Reset table preferences' link then click on one of the columns to change the sort direction, or collapse one of the columns.
      3. Check that the 'Reset table preferences' link is displayed
      4. Click on the link and then check that the link is no longer displayed.
      5. View a table that has neither persistent preferences nor collapsible columns, e.g. on the 'Manage local plugins' admin page
      6. Check that the 'Reset table preferences' link is not displayed.
      Show
      View a table that has either persistent preferences or collapsible columns, e.g. the assignment grading table If there is no 'Reset table preferences' link then click on one of the columns to change the sort direction, or collapse one of the columns. Check that the 'Reset table preferences' link is displayed Click on the link and then check that the link is no longer displayed. View a table that has neither persistent preferences nor collapsible columns, e.g. on the 'Manage local plugins' admin page Check that the 'Reset table preferences' link is not displayed.
    • Affected Branches:
      MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-51315-master

      Description

      I have noticed that when a flexible_table is used without sortable or collapsible columns it still displays "Reset table preferences". This is confusing.

      And my 2 unrelated cents, I am not sure I like the visual clutter caused by that link when the table preferences are not persistent and collapsible columns are not used. Collapsible columns can be an issue, so I agree that as soon as they are used we should offer to reset the preferences.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  16/Nov/15