[MDL-51374] Do not purge entire databasemeta cache when there are structure changes (esp temp tables). - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.9, 3.1
Fix Version/s: 3.1
Component/s: Caching, Database SQL/XMLDB
Labels:
- api_change
- ci
- performance
- release_notes
- triaged

Testing Instructions:
Hide

Pre-requisites

This issue must be tested on all supported databases, so please be patient.

Manual testing

Upgrade from 3.0 to master, make sure you don't see any errors.

Do multiple backup and restores, make sure you don't get errors and all data is properly restored on the destination course.

Do an exploratory testing creating courses, users, course modules, enrol, anyway an overall testing: inserting, updating and deleting information on the database.

Install plugins and remove plugins...

Create a new install, you should install without any problems.

Repeated steps above in the fresh install.

Unit tests

All unit tests should pass in all supported databases.
Show
Pre-requisites This issue must be tested on all supported databases, so please be patient. Manual testing Upgrade from 3.0 to master, make sure you don't see any errors. Do multiple backup and restores, make sure you don't get errors and all data is properly restored on the destination course. Do an exploratory testing creating courses, users, course modules, enrol, anyway an overall testing: inserting, updating and deleting information on the database. Install plugins and remove plugins... Create a new install, you should install without any problems. Repeated steps above in the fresh install. Unit tests All unit tests should pass in all supported databases.
Affected Branches:
MOODLE_29_STABLE, MOODLE_31_STABLE
Fixed Branches:
MOODLE_31_STABLE
Pull from Repository:
git://github.com/lameze/moodle.git
Pull Master Branch:
~~MDL-51374~~-master-new
Pull Master Diff URL:
https://github.com/lameze/moodle/compare/e8952c5...MDL-51374-master-new

Sprint:
3.1 Sprint 5

Description

Reported as a part of ~~MDL-49489~~ - the databasemeta cache is purged whenever a temp table is created. Perhaps it would be better to be more specific and purge only the affected table, or ignore purging the cache for temporary tables.

Attachments

Issue Links

blocks

MDL-53514 Delete databasemeta cache entries selectively

Open

caused a regression

MDL-57192 Database query logging fails with MySQLi (and possibly other drivers)

Closed

has a non-specific relationship to

MDL-52346 Show only valid cache types to administrator when configuring MUC

Closed

has been marked as being related by

MDL-50909 MDL-49489 Causes severe performance degradation of course index and search pages

Closed

MDL-53213 Make databasemeta cache a simpledata cache and improve performance

Closed

Activity

People

Assignee:: Simey Lameze

Reporter:: Damyon Wiese

Peer reviewer:: Damyon Wiese

Integrator:: David Monllaó

Tester:: Jun Pataleta

Participants:: Ankit Agarwal, CiBoT, Colin Campbell, Damyon Wiese, Dan Poltawski, David Monllaó, Eloy Lafuente (stronk7), Jun Pataleta, Martin Dougiamas, Matt Petro, Rajesh Taneja, Russell Smith, Simey Lameze

Component watchers:: Matteo Scaramuccia, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 10 Vote for this issue

Watchers:: 19 Start watching this issue

Dates

Created:: 10/Sep/15 10:53 PM

Updated:: 21/Dec/16 10:58 PM

Resolved:: 18/Mar/16 8:31 AM

Fix Release Date:: 23/May/16