Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51374

Do not purge entire databasemeta cache when there are structure changes (esp temp tables).

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-51374-master-new
    • Pull Master Diff URL:
    • Testing Instructions:
      Hide
      Pre-requisites

      This issue must be tested on all supported databases, so please be patient.

      Manual testing
      1. Upgrade from 3.0 to master, make sure you don't see any errors.
      2. Do multiple backup and restores, make sure you don't get errors and all data is properly restored on the destination course.
      3. Do an exploratory testing creating courses, users, course modules, enrol, anyway an overall testing: inserting, updating and deleting information on the database.
      4. Install plugins and remove plugins...
      5. Create a new install, you should install without any problems.
      6. Repeated steps above in the fresh install.
      Unit tests

      All unit tests should pass in all supported databases.

      Show
      Pre-requisites This issue must be tested on all supported databases, so please be patient. Manual testing Upgrade from 3.0 to master, make sure you don't see any errors. Do multiple backup and restores, make sure you don't get errors and all data is properly restored on the destination course. Do an exploratory testing creating courses, users, course modules, enrol, anyway an overall testing: inserting, updating and deleting information on the database. Install plugins and remove plugins... Create a new install, you should install without any problems. Repeated steps above in the fresh install. Unit tests All unit tests should pass in all supported databases.
    • Sprint:
      3.1 Sprint 5

      Description

      Reported as a part of MDL-49489 - the databasemeta cache is purged whenever a temp table is created. Perhaps it would be better to be more specific and purge only the affected table, or ignore purging the cache for temporary tables.

        Attachments

          Issue Links

          blocks

          Improvement - An enhancement to an existing Moodle feature. MDL-53514 Delete databasemeta cache entries selectively

          • Minor - Minor loss of function where workaround is possible
          • Open
          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-57192 Database query logging fails with MySQLi (and possibly other drivers)

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          has a non-specific relationship to

          Improvement - An enhancement to an existing Moodle feature. MDL-52346 Show only valid cache types to administrator when configuring MUC

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-50909 MDL-49489 Causes severe performance degradation of course index and search pages

          • Major - Major loss of function, incorrect output
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-53213 Make databasemeta cache a simpledata cache and improve performance

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              lameze Simey Lameze
              Reporter:
              damyon Damyon Wiese
              Peer reviewer:
              Damyon Wiese Damyon Wiese
              Integrator:
              David Monllaó David Monllaó
              Tester:
              Jun Pataleta Jun Pataleta
              Participants:
              Component watchers:
              Matteo Scaramuccia, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              10 Vote for this issue
              Watchers:
              19 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                23/May/16