Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51410

Missing notifysucess and hardcoded strings on survey report

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Manual testing:
      (Requires a course with a student and a teacher)

      1. Create a survey activity using the ATTLS survey type.
      2. Have the student complete the survey
      3. As the teacher view the "Participants" Report (View the survey, Administration block -> Survey Administration -> Response reports -> Participants .
      4. Click on the student's name
      5. Enter some text into "Your private analysis and notes:" and press "Save changes"
      6. Verify the save successful notification is "green"
      7. Edit the text into "Your private analysis and notes:" and trigger the error message on save (The easiest way to edit the test on line 398 of mod/survey/report.php by removing the !)
      8. Verify the error message is displayed in Red.
      Show
      Manual testing: (Requires a course with a student and a teacher) Create a survey activity using the ATTLS survey type. Have the student complete the survey As the teacher view the "Participants" Report (View the survey, Administration block -> Survey Administration -> Response reports -> Participants . Click on the student's name Enter some text into "Your private analysis and notes:" and press "Save changes" Verify the save successful notification is "green" Edit the text into "Your private analysis and notes:" and trigger the error message on save (The easiest way to edit the test on line 398 of mod/survey/report.php by removing the !) Verify the error message is displayed in Red.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull Master Branch:
      MDL-51410_m32v2

      Description

      When you browse an user survey report and add a private analysis and notes, the report displays the Your notes were saved message in red background, at first glance seems there was an error while saving the notes.

      It's just a matter of adding notifiysucess parameter on the

      $OUTPUT->notification(get_string("savednotes", "survey"), 'notifysuccess');

      There also hardocoded strings, that I think could be adress here too:

      echo $OUTPUT->notification("An error occurred while saving your notes.  Sorry.");
      

        Attachments

          Activity

            People

            Assignee:
            sbourget Stephen Bourget
            Reporter:
            lameze Simey Lameze
            Peer reviewer:
            Simey Lameze
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Adrian Greeve
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              12/Sep/16