Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51419

Filename corruption on download when name contains multibyte chars, in MS Edge.

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test on all supported browsers on windows and linux (mac already done, see comments)

      Excel export test

      1. Create a course named "Test course ☺" (and short-name "MDL☺")
      2. Enrol a student and
      3. Create an assignment
      4. Grade the student's submission
      5. Now, view Grades from the left hand menu
      6. Click the 'Export' tab and then select the 'Excel spreadsheet' tab.
      7. Make sure the course total is ticked, ticking if need be.
      8. Click 'Download'
      9. Verify that the download popup, if there is any, has the correct file name (contains course short-name).
      10. Download the file and verify the name is correct (contains course short-name).

      Resource test

      1. Create a resource and upload a text file named "Test file ☺" (also can use the file generated in the excel export test).
      2. Now, edit this resource and set Display (Under 'Appearance' section) to force download.
      3. Now, back on the course page, click the file.
      4. Verify that the download popup has the correct file name
      5. Download the file and verify the name is correct.
      Show
      Test on all supported browsers on windows and linux (mac already done, see comments) Excel export test Create a course named "Test course ☺" (and short-name "MDL☺") Enrol a student and Create an assignment Grade the student's submission Now, view Grades from the left hand menu Click the 'Export' tab and then select the 'Excel spreadsheet' tab. Make sure the course total is ticked, ticking if need be. Click 'Download' Verify that the download popup, if there is any, has the correct file name (contains course short-name). Download the file and verify the name is correct (contains course short-name). Resource test Create a resource and upload a text file named "Test file ☺" (also can use the file generated in the excel export test). Now, edit this resource and set Display (Under 'Appearance' section) to force download. Now, back on the course page, click the file. Verify that the download popup has the correct file name Download the file and verify the name is correct.
    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-51419-master

      Description

      When a file name has multibyte chars in it (e.g. an umlaut - ö), and a user downloads said file with Edge, Edge doesn't save the file with the correct name. Firefox and Chrome do save correctly.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                5 Vote for this issue
                Watchers:
                12 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Jul/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 15 minutes
                  1h 15m