Loading...

XML

Word

Printable

Affected Branches:
MOODLE_29_STABLE, MOODLE_30_STABLE
Fixed Branches:
MOODLE_28_STABLE, MOODLE_29_STABLE
Pull from Repository:
https://github.com/tlock/moodle.git
Pull Main Branch:
mdl51440-master
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...tlock:mdl51440-master
Testing Instructions:

Hide

1. Verify the Grade -> Import -> Paste from spreadsheet renders correctly.
2. Undo this fix so the page generates an error by changing require_once statement as follows:
require_once(_DIR_ . "/../../../config.php");
to
require_once(_DIR_ . "/../../../../config.php");
3. Refresh page and expect a require_once error:
require_once(/var/www/moodle/grade/import/direct/../../../../config.php)

Show
1. Verify the Grade -> Import -> Paste from spreadsheet renders correctly. 2. Undo this fix so the page generates an error by changing require_once statement as follows: require_once(_ DIR _ . "/../../../config.php"); to require_once(_ DIR _ . "/../../../../config.php"); 3. Refresh page and expect a require_once error: require_once(/var/www/moodle/grade/import/direct/../../../../config.php)

Currently when accessing the Grade -> Import -> Paste from spreadsheet it is trying to include the config.php file outside of the Moodle directory.

/var/www/moodle/grade/import/direct../../../../config.php

Moodle is removing the incorrect '..' so the page works correctly.

This issue changes so it is included like Import from CSV.

Participants:: CiBoT, Dan Poltawski, David Monllaó, Marina Glancy, Simey Lameze, Tim Lock