Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51443

Improve/remove get_enrolled_sql db caching trick

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.8.8
    • Fix Version/s: None
    • Component/s: Enrolments
    • Labels:
    • Affected Branches:
      MOODLE_28_STABLE

      Description

      Rajesh noticed that MDL-30157 was failing randomly, it is a race condition, get_enrolled_sql is checking (resuming) ue.timestart < time() instead of <=. I'm not sure why this is like this, but it might be intentional. I'm opening this issue to look at it and solving it if it should be fixed.

      The dirty hack we introduced in MDL-30157 last commit could be removed after this.

      Some other cases to review:

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              dmonllao David Monllaó
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated: