Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51486

Error dialogue with ratings in database.

    XMLWordPrintable

Details

    • MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
    • MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
    • wip-MDL-51486-master
    • Hide
      1. Have a course with students enrolled and in groups.
      2. Create a database activity.
        1. In ratings set the aggregate type to something.
        2. Set group mode in 'Common module settings' to 'Separate groups'
      3. Add a field.
      4. Save the templates.
      5. Create an entry as the administrator (This should be in the "All participants" group).
      6. Go to [Database activity administration ► Permissions] and add the student to:
        • mod/data:rate
        • mod/data:viewallratings
        • mod/data:viewanyrating
        • mod/data:viewrating
      7. Log on as a student and rate the admin's record.
      8. Log on as another student in a different group and do the same.
      9. Click on the link for the ratings.
      10. A window should pop up with a list of students that have rated this record. There should be no error regarding appropriate permissions.
      Show
      Have a course with students enrolled and in groups. Create a database activity. In ratings set the aggregate type to something. Set group mode in 'Common module settings' to 'Separate groups' Add a field. Save the templates. Create an entry as the administrator (This should be in the "All participants" group). Go to [Database activity administration ► Permissions] and add the student to: mod/data:rate mod/data:viewallratings mod/data:viewanyrating mod/data:viewrating Log on as a student and rate the admin's record. Log on as another student in a different group and do the same. Click on the link for the ratings. A window should pop up with a list of students that have rated this record. There should be no error regarding appropriate permissions.

    Description

      Message from Sam:

      Hi guys,
      Just sharing it looks like this introduced a wee regression in the database module.
      Set up so that ratings can be viewed by students
      Add an entry as an admin (or just priviledged non grouped user)
      Rate as a student of group 1
      Rate as a student of group 2
      Verify the rating link has (2) in brackets
      Click the link (still as student2)
      The dialog displays and you get a permission error.
      Prior to this you saw the two ratings.
      You do not have the capability to view item ratings
      More information about this error
      Debug info:
      Error code: noviewrate
      Stack trace:
      line 481 of /lib/setuplib.php: moodle_exception thrown
      line 65 of /rating/index.php: call to print_error()
      Reproduced in 2.7, and 2.9.

      Attachments

        Activity

          People

            abgreeve Adrian Greeve
            damyon Damyon Wiese
            Simey Lameze Simey Lameze
            Andrew Lyons Andrew Lyons
            Jun Pataleta Jun Pataleta
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              9/Nov/15