Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51515

Mod_assign view.php discard useridlist parameter

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.8, 2.9, 3.0
    • Fix Version/s: 2.9.4
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide

      Create an assignment in a course with at least 5 students.
      Go to the grading table for the assignment and change the sort order for the table.
      Click on the grade icon for one of the students in the middle of the list (not the first one).
      Make a note of which student you are grading.
      Expand the course administration nav tree and click "turn editing on" (or off).
      Verify you are still grading the same student.

      Show
      Create an assignment in a course with at least 5 students. Go to the grading table for the assignment and change the sort order for the table. Click on the grade icon for one of the students in the middle of the list (not the first one). Make a note of which student you are grading. Expand the course administration nav tree and click "turn editing on" (or off). Verify you are still grading the same student.
    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull Master Branch:
      MDL-51515-master

      Description

      The parameter useridlist used to identify the list of student in the cache is badly read in /mod/assign/view.php :
      lines 30-33:

      $urlparams = array('id' => $id,
                        'action' => optional_param('action', '', PARAM_TEXT),
                        'rownum' => optional_param('rownum', 0, PARAM_INT),
                        'useridlistid' => optional_param('action', 0, PARAM_INT));
      

      Specifically, it's assigning the integer value of the "action" text field to the "useridlistid" setting.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Jan/16