Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51517

Clean up buttons.less

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.8, 2.9.2, 3.0
    • Fix Version/s: 3.0
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Please Note: All buttons that are classed as 'singlebuttons' look the same wherever they are on a page. However NOT all buttons are 'singlebuttons', some are 'grouped'.

      1. With Clean theme selected go to your 'Dashboard' page.
      2. Verify that the 'Customise this page' button is positioned close up to the edge of the page on the right and clear of the content below it.
      3. Test as No.2 above using a RTL language such as HE (Hebrew), but verify that the button is now on the left.
      4. Go to any course page and Edit settings. Here you should see two form buttons one blue, one white with a space between.
      5. Verify that these buttons are equally spaced apart and on the left.
      6. Test as No.5 above using a RTL language such as HE (Hebrew), but verify that the buttons are now on the right.
      7. Still in a course page turn editing on ADD a Wiki page and verify when setting up that there are a group of three buttons.
      8. Verify that these are equally spaced and on the left.
      9. Test as No.8 above using a RTL language such as HE (Hebrew), but verify that the buttons are now on the right.
      Show
      Please Note: All buttons that are classed as 'singlebuttons' look the same wherever they are on a page. However NOT all buttons are 'singlebuttons', some are 'grouped'. With Clean theme selected go to your 'Dashboard' page. Verify that the 'Customise this page' button is positioned close up to the edge of the page on the right and clear of the content below it. Test as No.2 above using a RTL language such as HE (Hebrew), but verify that the button is now on the left. Go to any course page and Edit settings. Here you should see two form buttons one blue, one white with a space between. Verify that these buttons are equally spaced apart and on the left. Test as No.5 above using a RTL language such as HE (Hebrew), but verify that the buttons are now on the right. Still in a course page turn editing on ADD a Wiki page and verify when setting up that there are a group of three buttons. Verify that these are equally spaced and on the left. Test as No.8 above using a RTL language such as HE (Hebrew), but verify that the buttons are now on the right.
    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull Master Branch:
      MDL-51517_master

      Description

      In trying to fix MDL-51127 I found that theme/bootstrapbase/less/moodle/buttons.less held some CSS mark-up which, over time, had been overridden by other CSS fixes that, in effect rendered them obsolete.

      Also in MDL-51127 it came to light that some other CSS mark-up which Gareth J Barnard confirmed he had tided up in 2013 were perhaps not needed either as they too were being overridden in subsequent CSS fixes scattered about the LESS files.

      The aim in this issue, however, is just to convert the CSS to LESS and make way for a better way of styling buttons as it is clear the problem stems not from the generated CSS, but from the HTML mark-up when the buttons are being created. We need to change the way buttons are coded!

        Attachments

        1. change_password_integration.png
          change_password_integration.png
          23 kB
        2. change_password_patched.png
          change_password_patched.png
          23 kB
        3. login_integration.png
          login_integration.png
          99 kB
        4. login_patched.png
          login_patched.png
          84 kB
        5. misaligned buttons.png
          misaligned buttons.png
          139 kB
        6. misaligned buttons 2.png
          misaligned buttons 2.png
          168 kB
        7. Screen Shot 2015-10-13 at 4.51.25 PM.png
          Screen Shot 2015-10-13 at 4.51.25 PM.png
          24 kB

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  16/Nov/15