Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51564

Review the use of format_string in external functions

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9.2
    • Fix Version/s: 3.0
    • Component/s: Web Services
    • Labels:
    • Testing Instructions:
      Hide

      The best way to check that nothing is broken is via the Moodle Mobile app:

      1. Create a course with a IMS CP package (you can use the one in mod/scorm/tests), a BOOK activity and a choice
      2. In your Moodle site Enable the Mobile service (Plugins -> WebServices -> Mobile)
      3. Then, access a course using the Mobile app.
      4. Browse the course contents and access to the Choice, Book and IMS CP activities
      5. You shouldn't see any error and the text should be correctly formatted (if the app detects any error it will display a modal for "Reporting errors")
      Show
      The best way to check that nothing is broken is via the Moodle Mobile app: Create a course with a IMS CP package (you can use the one in mod/scorm/tests), a BOOK activity and a choice In your Moodle site Enable the Mobile service (Plugins -> WebServices -> Mobile) Then, access a course using the Mobile app. Browse the course contents and access to the Choice, Book and IMS CP activities You shouldn't see any error and the text should be correctly formatted (if the app detects any error it will display a modal for "Reporting errors")
    • Affected Branches:
      MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-51564-master

      Description

      We should use external_format_string instead (see MDL-51213) and replace PARAM_HTML with PARAM_RAW in some cases

        Attachments

          Activity

            People

            Assignee:
            jleyva Juan Leyva
            Reporter:
            jleyva Juan Leyva
            Peer reviewer:
            Adrian Greeve
            Integrator:
            Dan Poltawski
            Tester:
            cameron1729
            Participants:
            Component watchers:
            Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              16/Nov/15