Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51582

Switch to grunt to compile LESS as recess is no longer maintained

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      (You will need to run grunt installed (https://docs.moodle.org/dev/Grunt) and run npm install to get the new package)

      1. Compare Moodle before and after the patch and ensure there are no visual differences caused by CSS. Pick some elements at random and compare the CSS applied
      2. Run grunt css
      3. VERIFY: no changes are generated
      4. Change a less file
      5. Run grunt css
      6. VERIFY: changes are generated in css files
      7. Run grunt js
      8. VERIFY: only jshint, uglify and shifter tasks are run
      9. # Run grunt amd
      10. VERIFY: only jshint and uglify tasks are run
      11. Run grunt in top level directory
      12. VERIFY: it runs all tasks (less:bootstrapbase, jshint, uglify, shifter)
      13. Run grunt in an /amd/ directory
      14. VERIFY: it runs only amd tasks (jshint/uglify)
      Show
      (You will need to run grunt installed ( https://docs.moodle.org/dev/Grunt ) and run npm install to get the new package) Compare Moodle before and after the patch and ensure there are no visual differences caused by CSS. Pick some elements at random and compare the CSS applied Run grunt css VERIFY: no changes are generated Change a less file Run grunt css VERIFY: changes are generated in css files Run grunt js VERIFY: only jshint, uglify and shifter tasks are run # Run grunt amd VERIFY: only jshint and uglify tasks are run Run grunt in top level directory VERIFY: it runs all tasks (less:bootstrapbase, jshint, uglify, shifter) Run grunt in an /amd/ directory VERIFY: it runs only amd tasks (jshint/uglify)
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull Master Branch:
      MDL-51582-master

      Description

      While trying to use recess to compile a fix a CSS issue in bootstrapbase I notice it does not work anymore, only to find out that two months ago the recess project updated their README on github with "recess - no longer maintained, does not work with newer less versions" : https://github.com/twitter/recess .

      Looking at Moodle's theme/bootstrapbase/less/README, I used lessc instead which worked fine for theme/clean, but for theme/more It seemed redundant as it uses lessphp to compile less files on-the-fly.

      I suggest we updated the instructions in the README file and find an alternative. although we are already using lessphp.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                15 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  21/Dec/15