Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-5162

Deprecated elements in messages block

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.6
    • Fix Version/s: 1.8
    • Component/s: Accessibility, Blocks
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_16_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE

      Description

      The message block contains deprecated elements

      <div class=content>

      <center>

      <font size=-1>No messages waiting</font>

      </center>

      <div class=footer>

      <a target=message href=http://danielehome.local/~Daniele/moodle16/message/index.php onclick=return openpopup('/message/index.php', 'message', 'menubar=0,location=0,scrollbars,status,resizable,width=400,height=500', 0);>Messages</a>...

      </div>

      </div>

      To change it to following, for istance, the Latest News block behaviour just change the row 47 of

      moodle/blocks/messages/Blocks_messages.php

      from

      $this->content->text .= <center><font size=-1\>.get_string('nomessages', 'message').</font></center>;

      to

      $this->content->text .= get_string('nomessages', 'message');

      By changing this, it shoud be the right time to create a css for this block.

      Attached is a the upgraded messages.php and new css proposal.

      I know it is nothing, but I believe your time is for more deep and serious develop and bug fix.

      So, if you believe what I wrote is correct, this is my contibution.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                skodak Petr Skoda
                Reporter:
                daniss Daniele Cordella
                Tester:
                Nobody
                Participants:
                Component watchers:
                Adrian Greeve, Mihail Geshoski, Peter Dias, Adrian Greeve, Mihail Geshoski, Peter Dias
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  31/Mar/07