Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51651

First day of week is 'Monday' in en_au and javascript popups don't use first day user preference

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.9.2
    • 2.8.9, 2.9.3
    • Language
    • MOODLE_29_STABLE
    • MOODLE_28_STABLE, MOODLE_29_STABLE
    • MDL-51651-master
    • Hide

      Install test - install moodle using the full installer (no config.php)

      1. In installer select language as American English (en_us)
      2. Go to Site administration > Appearance > Calendar
      3. VERIFY 'calendar_startwday' is set to Sunday
      1. In installer select language as English (en)
      2. Go to Site administration > Appearance > Calendar
      3. VERIFY 'calendar_startwday' is set to Monday

      Preference test

      1. Go to /calendar/ and set your first day of week preference to something crazy like 'wednesday'
      2. Add a new course and chose the javascript date popup for the course start date
      3. VERIFY: the date picker should start on wednesday which you picked above
      4. Change you preference in the calendar settings, and verify the picker changes
      Show
      Install test - install moodle using the full installer (no config.php) In installer select language as American English (en_us) Go to Site administration > Appearance > Calendar VERIFY 'calendar_startwday' is set to Sunday In installer select language as English (en) Go to Site administration > Appearance > Calendar VERIFY 'calendar_startwday' is set to Monday Preference test Go to /calendar/ and set your first day of week preference to something crazy like 'wednesday' Add a new course and chose the javascript date popup for the course start date VERIFY: the date picker should start on wednesday which you picked above Change you preference in the calendar settings, and verify the picker changes

    Description

      As reported by poltawski in https://lang.moodle.org/local/amos/contrib.php?id=11784

      Discovered while integrating MDL-49440 - the core en langpack makes firstdayofweek 0 - which results in Sunday. I think this is an en_us default and in Australian English, Monday is the correct choice.

      i.e. firstdayofweek should be 0 in en_us and 1 in en in langconfig.php

      Attachments

        Issue Links

          Activity

            People

              poltawski Dan Poltawski
              tsala Helen Foster
              Helen Foster Helen Foster
              Andrew Lyons Andrew Lyons
              Jun Pataleta Jun Pataleta
              Aya Saad, David Mudrák (@mudrd8mz), Helen Foster, Victor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Nov/15