[MDL-51664] Improve external_util::validate_courses to prevent double course fetching - Moodle Tracker

XML

Word

Printable

Details

Type: Task
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.9.2
Fix Version/s: 3.1
Component/s: Web Services
Labels:
- ci
- triaged

Testing Instructions:
1. Run lib/tests/externallib_test.php
Affected Branches:
MOODLE_29_STABLE
Fixed Branches:
MOODLE_31_STABLE
Pull from Repository:
git://github.com/FMCorz/moodle.git
Pull Master Branch:
~~MDL-51664~~-master
Pull Master Diff URL:
https://github.com/FMCorz/moodle/compare/74fad2c...MDL-51664-master

Description

There are external functions in which we retrieve the list of courses a user has access to, and the we call validate_courses which fetches the course again. We should pass an array of prefetched courses to validate_courses to prevent unnecessary double fetching.

Attachments

Issue Links

blocks

MDL-50540 mod_glossary_get_glossaries_by_courses

Closed

MDL-50550 mod_wiki_get_wikis_by_courses

Closed

MDL-51929 Improve mod_survey, mod_lti and mod_data get_xxx_by_courses external function

Closed

has a non-specific relationship to

MDL-50540 mod_glossary_get_glossaries_by_courses

Closed

Activity

People

Assignee:: Frédéric Massart

Reporter:: Frédéric Massart

Peer reviewer:: Juan Leyva

Integrator:: Dan Poltawski

Tester:: CiBoT

Participants:: CiBoT, Dan Poltawski, Eloy Lafuente (stronk7), Frédéric Massart, Juan Leyva, Marina Glancy, Rajesh Taneja

Component watchers:: Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 06/Oct/15 12:21 AM

Updated:: 04/Dec/15 2:49 PM

Resolved:: 04/Dec/15 2:49 PM

Fix Release Date:: 23/May/16