Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51691

Feedback Comments can not be deleted with savequickgrading

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Create a course.
      2. Enrol 2 students.
      3. Create an assignment and make sure "Feedback comments" is ticked.
      4. Log in as Teacher.
      5. Go to the assignment activity.
      6. Click "View all submissions".
      7. Grade student1's work and enter "test comments" in Feedback comments area.
      8. Go back to the assignment grading page.
      9. Tick Options / Quick grading.
      10. Type "test comments 2" in Feedback comments for student2.
      11. Click "Save all quick grading changes".
      12. Go back to the assignment grading page.
      13. Make sure that Options / Quick grading is still ticked.
      14. Delete feedback comments for student1.
      15. Click "Save all quick grading page".

      Before the patch: You will see that the existing comments were not deleted.

      Expected: The comments should be deleted.

      Show
      Create a course. Enrol 2 students. Create an assignment and make sure "Feedback comments" is ticked. Log in as Teacher. Go to the assignment activity. Click "View all submissions". Grade student1's work and enter "test comments" in Feedback comments area. Go back to the assignment grading page. Tick Options / Quick grading. Type "test comments 2" in Feedback comments for student2. Click "Save all quick grading changes". Go back to the assignment grading page. Make sure that Options / Quick grading is still ticked. Delete feedback comments for student1. Click "Save all quick grading page". Before the patch: You will see that the existing comments were not deleted. Expected: The comments should be deleted.
    • Affected Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull Master Branch:
      MDL-51691-master

      Description

      Create and assignment with "feedback comments" option enabled.
      go to View/grade all submissions and turn quick grading on
      enter a comment to a student and save quick grading.
      go back to gradebook again and delete the comment you just added.
      click on save quick grading, you will see all changes saved message but it actually is not saving the deletion.
      you can only delete the comment from individual student grading/feedback screen one by one.

        Attachments

          Activity

            People

            Assignee:
            jebarvia Joshua Ebarvia
            Reporter:
            samsamet A. Samet Kul
            Peer reviewer:
            Marcus Green
            Integrator:
            Jake Dallimore
            Tester:
            Ankit Agarwal
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            3 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/Jul/17