[MDL-51703] response_submitted event can be triggered even when the survey is already submitted - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_28_STABLE, MOODLE_29_STABLE
Fixed Branches:
MOODLE_28_STABLE, MOODLE_29_STABLE
Pull from Repository:
git://github.com/jleyva/moodle.git
Testing Instructions:
Hide

Create a new survey (the type doesn't mind)

Using a student user submit the survey

Just once you see the "Thanks for answering this survey,"message reload the page again (F5 or Cmd+R to submit the form again)

You should see an error ('You have already submitted this survey')

Go to the Activity logs and check that the "Survey response submitted" event does not appear two times in the log
Show
Create a new survey (the type doesn't mind) Using a student user submit the survey Just once you see the "Thanks for answering this survey,"message reload the page again (F5 or Cmd+R to submit the form again) You should see an error ('You have already submitted this survey') Go to the Activity logs and check that the "Survey response submitted" event does not appear two times in the log

This was discovering while developing: ~~MDL-51629~~

The event triggering must be moved to the end of the code (before printing the thanks message)

Discovered while testing

MDL-51629 New Web Services for mod_survey

Participants:: Adrian Greeve, CiBoT, Dan Poltawski, Eloy Lafuente (stronk7), Juan Leyva, Simey Lameze

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Sabina Abellan, Sara Arjona (@sarjona)