Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51719

Atto RTL plugin does not highlight state

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.8, 2.9.2, 2.9.3, 3.0.1, 3.1
    • Fix Version/s: 2.9.4, 3.0.2
    • Component/s: HTML Editor (Atto)
    • Labels:
    • Testing Instructions:
      Hide
      1. (Make sure you are using atto editor)
      2. In Admin > Plugins > Text editors > Atto > Atto toolbar settings.. add 'rtl' to one of the toolbar sections - so the rtl toolbar displays
      3. Save settings
      4. Go to an atto editor and make sure you can see the rtl/ltr buttons
      5. Add three paragraphs and highlight the first
        1. VERIFY: That neither button is highlighted
      6. Click on The LTR button
        1. VERIFY: that the button is now highlighted
      7. highlight the second paragraph
        1. VERIFY: That neither button is highlighted
      8. Click on the RTL button
        1. VERIFY: that the button is now highlighted
      9. highlight the third paragraph
      10. Click on the RTL button
        1. VERIFY: that the button is now highlighted
      11. Click on the RTL button again
        1. VERIFY: that the button is no longer highlighted
        2. VERIFY: that the other button is now highlighted
      12. Highlight on the first paragraph again
        1. VERIFY that the RTL button is highlighted
      13. Highlight on the second paragraph again
        1. VERIFY that the LTR button is highlighted
      14. Highlight on the third paragraph again
        1. VERIFY that the LTR button is highlighted
      15. VERIFY that this matches the html in the source view
      Show
      (Make sure you are using atto editor) In Admin > Plugins > Text editors > Atto > Atto toolbar settings.. add 'rtl' to one of the toolbar sections - so the rtl toolbar displays Save settings Go to an atto editor and make sure you can see the rtl/ltr buttons Add three paragraphs and highlight the first VERIFY: That neither button is highlighted Click on The LTR button VERIFY: that the button is now highlighted highlight the second paragraph VERIFY: That neither button is highlighted Click on the RTL button VERIFY: that the button is now highlighted highlight the third paragraph Click on the RTL button VERIFY: that the button is now highlighted Click on the RTL button again VERIFY: that the button is no longer highlighted VERIFY: that the other button is now highlighted Highlight on the first paragraph again VERIFY that the RTL button is highlighted Highlight on the second paragraph again VERIFY that the LTR button is highlighted Highlight on the third paragraph again VERIFY that the LTR button is highlighted VERIFY that this matches the html in the source view
    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull Master Branch:
      MDL-51719-master

      Description

      Unlike with bold, italic, etc. the RTL plugin does not highlight the button to show its current state.

      This should be as easy as adding a tags: '[dir=rtl]' configuratino to the addButton call.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              poltawski Dan Poltawski
              Reporter:
              dobedobedoh Andrew Nicols
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              cameron1729
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Jan/16