[MDL-51737] Add ability to detect MS Edge in our browser sniffing code - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 3.0
Fix Version/s: 3.0
Component/s: Libraries
Labels:
- api_change
- ci
- triaged

Testing Instructions:
1. Run unit tests
1. Put the attached php file in your web root
2. Browse to the php file
3. VERIFY: you get 'is edge' in MS edge, and get 'is not edge' in other browsers.
Affected Branches:
MOODLE_30_STABLE
Fixed Branches:
MOODLE_30_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Master Branch:
~~MDL-51737~~-master-3
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/74fad2ce3de05ce158bf6588c20bb277154d8d9d...MDL-51737-master-3

Description

Add support for detecting MS Edge browser, in core_useragent etc.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

test-edge.php
0.1 kB
23/Oct/15 5:47 AM

Issue Links

has a non-specific relationship to

MDL-50812 core_useragent::get_browser_version_classes does not distinguish Chrome and Safari and don't know Edge

Closed

Activity

People

Assignee:

Andrew Nicols

Reporter:

Rajesh Taneja

Peer reviewer:

cameron1729

Integrator:

Dan Poltawski

Tester:

Adrian Greeve

Participants:

Adrian Greeve, Andrew Nicols, cameron1729, CiBoT, Damyon Wiese, Dan Poltawski, David Monllaó, Eloy Lafuente (stronk7), Marina Glancy, Rajesh Taneja

Component watchers:

Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón

Votes:

0 Vote for this issue

Watchers:

8 Start watching this issue

Dates

Created:

13/Oct/15 7:13 PM

Updated:

10/Apr/18 3:12 AM

Resolved:

24/Oct/15 7:12 AM

Fix Release Date:

16/Nov/15