Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51756

Webservice does not warn when external_function_parameters contains invalid VALUE_OPTIONAL

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-51756-master
    • Pull Master Diff URL:
    • Testing Instructions:
      Hide

      Run unit tests (./vendor/bin/phpunit lib/tests/externallib_test.php) on all branches. Verify they pass.

      On master revert 4d9edf1b152f24a770c93b4debddad52d91c6557 and re-run the test. It should fail.

      On 29 revert 0a646216446b3b56c48bc0a1dc9e67dd79de56a8 and re-run the test. It should fail.

      Show
      Run unit tests (./vendor/bin/phpunit lib/tests/externallib_test.php) on all branches. Verify they pass. On master revert 4d9edf1b152f24a770c93b4debddad52d91c6557 and re-run the test. It should fail. On 29 revert 0a646216446b3b56c48bc0a1dc9e67dd79de56a8 and re-run the test. It should fail.

      Description

      This is something easy to check - and should trigger debugging messages.

        Attachments

          Issue Links

          Discovered while testing

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-51536 Upgrade zend library to 1.12.16 for Moodle 3.0 release

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-52210 Remove Zend AMF from Moodle's AMF web service

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              damyon Damyon Wiese
              Reporter:
              damyon Damyon Wiese
              Peer reviewer:
              Dan Poltawski Dan Poltawski
              Integrator:
              Andrew Lyons Andrew Lyons
              Tester:
              Rajesh Taneja Rajesh Taneja
              Participants:
              Component watchers:
              Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Nov/15