[MDL-51756] Webservice does not warn when external_function_parameters contains invalid VALUE_OPTIONAL - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_28_STABLE, MOODLE_29_STABLE
Fixed Branches:
MOODLE_28_STABLE, MOODLE_29_STABLE
Pull from Repository:
git://github.com/damyon/moodle.git
Pull Master Branch:
~~MDL-51756~~-master
Pull Master Diff URL:
https://github.com/damyon/moodle/compare/74fad2c...MDL-51756-master
Testing Instructions:

Hide

Run unit tests (./vendor/bin/phpunit lib/tests/externallib_test.php) on all branches. Verify they pass.

On master revert 4d9edf1b152f24a770c93b4debddad52d91c6557 and re-run the test. It should fail.

On 29 revert 0a646216446b3b56c48bc0a1dc9e67dd79de56a8 and re-run the test. It should fail.

Show
Run unit tests (./vendor/bin/phpunit lib/tests/externallib_test.php) on all branches. Verify they pass. On master revert 4d9edf1b152f24a770c93b4debddad52d91c6557 and re-run the test. It should fail. On 29 revert 0a646216446b3b56c48bc0a1dc9e67dd79de56a8 and re-run the test. It should fail.

This is something easy to check - and should trigger debugging messages.

Discovered while testing

MDL-51536 Upgrade zend library to 1.12.16 for Moodle 3.0 release

has been marked as being related by

MDL-52210 Remove Zend AMF from Moodle's AMF web service

Participants:: Andrew Lyons, CiBoT, Damyon Wiese, Dan Poltawski, Eloy Lafuente (stronk7), Helen Foster, Rajesh Taneja, Tim Hunt

Component watchers:: Juan Leyva, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo