Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51792

When autocomplete form element only allows one selection, do not show X in selected items list + deleting tags with keyboard removes them from official list

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0
    • Fix Version/s: 3.0
    • Component/s: Forms Library
    • Labels:
    • Testing Instructions:
      Hide
      1. Check out the testing commit at the end of this patch.
      2. Load the test form page in the browser (/test.php in your moodle instance).
      3. Confirm that the single select box (one at the top) doesn't have the cross in the selected item (unlike the items in the multi-select box).
      4. Select a few items from the multi-select boxes (multi, tags etc) and confirm that when the item is selected that it no longer shows up in the available options
      5. Click on some of the items you selected above and confirm that they are removed from the selected list
      6. Confirm that the items removed in the point above are now available again in the list of options for that select field (when you click the down arrow)
      7. Repeat the above steps for the multi-select boxes but this time use the keyboard navigation. The behaviour should be the same as with using the mouse.
        • To remove selected items you need to tab focus the selection group, then use up and down to navigate the group and select the item you wish to delete. When an item is selected then hitting enter will deselect it.
      Show
      Check out the testing commit at the end of this patch. Load the test form page in the browser (/test.php in your moodle instance). Confirm that the single select box (one at the top) doesn't have the cross in the selected item (unlike the items in the multi-select box). Select a few items from the multi-select boxes (multi, tags etc) and confirm that when the item is selected that it no longer shows up in the available options Click on some of the items you selected above and confirm that they are removed from the selected list Confirm that the items removed in the point above are now available again in the list of options for that select field (when you click the down arrow) Repeat the above steps for the multi-select boxes but this time use the keyboard navigation. The behaviour should be the same as with using the mouse. To remove selected items you need to tab focus the selection group, then use up and down to navigate the group and select the item you wish to delete. When an item is selected then hitting enter will deselect it.
    • Affected Branches:
      MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull Master Branch:
      MDL-51792-master

      Description

      Mark suggested this while testing MDL-51247.

      1 when it is not possible to "deselect" something, don't add X to the items in the selected items list.
      2 when something is removed from the selected items list, it is not added back to the official tags list (via keyboard - it works with mouse).

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  16/Nov/15