Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51814

Unable to cancel installation of a subplugin

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.0
    • Fix Version/s: None
    • Component/s: Administration
    • Labels:
      None
    • Affected Branches:
      MOODLE_30_STABLE

      Description

      As discovered by Dan Poltawski while reviewing MDL-49329 (the comment), there is no way to cancel installation of a subplugin.

      I ended up with with workshop evaluation method which could not be cancelled from installation

      My response was

      I see. Hmm. This is because core_plugin_manager::can_cancel_plugin_installation() returns false for all subplugins. I remember adding that because I was in another situation: I tried to install mod_hotpot which comes with many subplugins in its package. In that case, the subplugins coming as a part of the parent plugin must not be cancellable because the parent module can implicitly require them to work properly.

      We would somehow need to recognize that the subplugin is being installed independently and not as a part of the parent plugin. Not sure at the moment how to do that reliably...

      Well, we could at least cover the scenario that (1) the parent plugin is a standard one and (2) the subplugin is additional. In that case, it is reasonable to expect that the subplugin's installation can be safely cancelled.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              mudrd8mz David Mudrák (@mudrd8mz)
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated: