Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51832

Unit test core_update_code_manager_testcase::test_list_plugin_folder_files() fails on Windows

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0
    • Fix Version/s: 3.0
    • Component/s: Administration, Unit tests
    • Labels:

      Description

      As reported by Eloy Lafuente (stronk7) in MDL-49329 comment
      https://tracker.moodle.org/browse/MDL-49329?focusedCommentId=377533&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-377533 there is one new unit test failing on Windows.

      Windows use backslash as the directory separator so the full paths comparison fails. After several prototypes, we agreed that the best approach is to normalize the paths returned by the list_plugin_folder_files() method so that it always uses forward slashes on all platforms.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                mudrd8mz David Mudrák (@mudrd8mz)
                Reporter:
                mudrd8mz David Mudrák (@mudrd8mz)
                Integrator:
                Eloy Lafuente (stronk7)
                Tester:
                Eloy Lafuente (stronk7)
                Participants:
                Component watchers:
                Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  16/Nov/15