Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51841

Auto complete fields should allow entering in spaces.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0
    • Fix Version/s: 3.0
    • Component/s: Forms Library
    • Labels:
    • Testing Instructions:
      Hide
      1. Check out this commit for testing this fix https://github.com/ryanwyllie/moodle/commit/dcece3952d155c6926e33689551e6d9710dcbd9d
      2. Load the test form page in the browser (/test.php in your moodle instance).
      3. In "Tags" and "Tags Optional" try creating a tag with a space in it.
        • Make sure that clicking a tag will remove it.
        • Do the same with the keyboard and make sure that using the space bar will remove the tag.
          • Add custom tags and also select some tags from the list.
          • Navigate to the selected tags above the autocomplete field with the keyboard and use up and down to 'highlight' a tag. Highlighted tags selected via the keyboard will be shown as bigger than the other tags.
          • Pressing 'space' should delete the selected tag.
          • Repeat the navigation of the selected tags and have a tag 'highlighted'. Then go back into the search text box and enter in a tag with a space. Hitting the space when entering in the word should not delete the 'highlighted' tag.
        • Check that keyboard navigation is possible with the different fields.
      Show
      Check out this commit for testing this fix https://github.com/ryanwyllie/moodle/commit/dcece3952d155c6926e33689551e6d9710dcbd9d Load the test form page in the browser (/test.php in your moodle instance). In "Tags" and "Tags Optional" try creating a tag with a space in it. Make sure that clicking a tag will remove it. Do the same with the keyboard and make sure that using the space bar will remove the tag. Add custom tags and also select some tags from the list. Navigate to the selected tags above the autocomplete field with the keyboard and use up and down to 'highlight' a tag. Highlighted tags selected via the keyboard will be shown as bigger than the other tags. Pressing 'space' should delete the selected tag. Repeat the navigation of the selected tags and have a tag 'highlighted'. Then go back into the search text box and enter in a tag with a space. Hitting the space when entering in the word should not delete the 'highlighted' tag. Check that keyboard navigation is possible with the different fields.
    • Affected Branches:
      MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-51841-master

      Description

      The autocomplete fields don't allow spaces to be entered.

      Trying to enter in a two word tag such as "red hot" is not possible.
      Also searching for an option with more than one word could be cumbersome.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              abgreeve Adrian Greeve
              Reporter:
              abgreeve Adrian Greeve
              Peer reviewer:
              Damyon Wiese
              Integrator:
              Andrew Nicols
              Tester:
              Simey Lameze
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                16/Nov/15