Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51853

Calendar subscriptions from imported files need to be editable

    XMLWordPrintable

Details

    • New Feature
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.9, 3.2
    • 3.3
    • Calendar
    • MOODLE_29_STABLE, MOODLE_32_STABLE
    • MOODLE_33_STABLE
    • MDL-51853_m33v3
    • Easy
    • Hide

      Automated testing (does not need tester action):

      1. Run the behat tests for the calendar

      Manual testing:

      1. Using Ical or another calendar. create a ICS file with a two events in the future
      2. Import that ICS file into moodle
      3. Edit one of the two events.
      4. Verify that a warning is displayed when editing the evnet
      5. Remove the calendar subscription for the ICS file.
      6. Verify the modified entry was removed.
      7. Add an ICal file via URL (such as a google calendar)
      8. Verify that you cannot edit entries that were added via the google calendar.
      Show
      Automated testing (does not need tester action): Run the behat tests for the calendar Manual testing: Using Ical or another calendar. create a ICS file with a two events in the future Import that ICS file into moodle Edit one of the two events. Verify that a warning is displayed when editing the evnet Remove the calendar subscription for the ICS file. Verify the modified entry was removed. Add an ICal file via URL (such as a google calendar) Verify that you cannot edit entries that were added via the google calendar.

    Description

      Currently, if a user or admin uploads a calendar according to the directions in https://docs.moodle.org/29/en/Calendar_import Moodle will treat it as a calendar subscription and prevent the imported events from being edited or deleted.

      This approach makes sense when the subscribed calendar is via a link (i.e. linked to a Google calendar) because any edited events will be overwritten as soon as the calendar is refreshed (see https://tracker.moodle.org/browse/MDL-36276).

      However, this does not make sense for calendars imported via a file since they are not linked to anything. Most often, these events are uploaded in a "one-shot" manner, for example, if a school wishes to populate the Moodle calendar with events for the entire year. However, in the aforementioned example, it is often quite necessary to make changes to these events and having to edit another document followed by uploading the calendar every time a change is needed makes for a terrible workflow.

      Therefore, when dealing with calendar imports:

      • events created via uploaded files should be allowed to be edited and deleted
      • events created via calendar links should remain as is, not editable

      Attachments

        Issue Links

          Activity

            People

              sbourget Stephen Bourget
              moodleboy Paul Prencis
              Marina Glancy Marina Glancy
              Andrew Lyons Andrew Lyons
              Dan Poltawski Dan Poltawski
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              3 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                15/May/17