Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51860

Changing configuration of blocks on admin pages is not reversable

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Won't Do
    • 2.9.2
    • None
    • Administration, Blocks
    • MOODLE_29_STABLE

    Description

      • navigate to /admin/
      • turn editing on
      • configure the Administration block
      • change "Display on page types" to "The current site administration page"
      • The block is now hidden from non admin pages (expected)
      • configure the Administration block again (from /admin/)
      • Option for "Any page" is removed from "Display on page types" and the block is forever lost from non admin pages.

      I had to fix this manually by setting pagetypepattern='*' in block_instances table for the settings id

      Seems this line is to blame in code: https://github.com/moodle/moodle/blob/MOODLE_29_STABLE/lib/blocklib.php#L1844 because currentcontext and parentcontext are the same.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              jtomkinson Jordan Tomkinson
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: