Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51864

block_course_summary don't display title

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.8.9, 2.9.3
    • 2.8.8, 2.9.2, 3.0
    • Blocks, Course
    • MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
    • MOODLE_28_STABLE, MOODLE_29_STABLE
    • MDL-51864-master
    • Hide

      Behat

      1. Run behat tests for tag @block_course_summary. Confirm that no failures occur.

      Front page

      1. Login as an admin.
      2. On the Navigation block, click Site home.
      3. On the Front page settings block, click Edit settings.
      4. Enter text for the Front page summary.
      5. Click Save changes
      6. Click Site home again.
      7. Check the front page. Confirm that
      • The front page summary block containing the previously entered summary text is displayed.
      • The title for the front page summary block is not being displayed.

      Course page

      1. Login as an admin.
      2. Create a course. Make sure to enter text for the course summary. Save the course then go to the course page.
      3. Under the Course administration block, click Turn editing on.
      4. Under the Add a block, select Course/site summary.
      5. Confirm that
      • The course summary block is being displayed.
      • The course summary block shows the title "Course summary"
      • The text entered previously in the course summary is displayed in the course summary block.
      Show
      Behat Run behat tests for tag @block_course_summary. Confirm that no failures occur. Front page Login as an admin. On the Navigation block, click Site home. On the Front page settings block, click Edit settings. Enter text for the Front page summary. Click Save changes Click Site home again. Check the front page. Confirm that The front page summary block containing the previously entered summary text is displayed. The title for the front page summary block is not being displayed. Course page Login as an admin. Create a course. Make sure to enter text for the course summary. Save the course then go to the course page. Under the Course administration block, click Turn editing on. Under the Add a block, select Course/site summary. Confirm that The course summary block is being displayed. The course summary block shows the title "Course summary" The text entered previously in the course summary is displayed in the course summary block.

      It was observed while testing MDLQA-8418, that block_course_summary is not displaying title.

      This is being caused by https://github.com/rajeshtaneja/moodle/blob/master/blocks/course_summary/block_course_summary.php#L35, where pagetype is expected to be exact match of course-view. Which is not true as 

      course-view-{format}

      is the page type for course.

      lib/blocklib.php and lib/outputrenderers.php do check for course-view-*, but not block_course_summary.

        1. screenshot-1.png
          screenshot-1.png
          35 kB

            jpataleta Jun Pataleta
            rajeshtaneja Rajesh Taneja
            Rajesh Taneja Rajesh Taneja
            Andrew Lyons Andrew Lyons
            John Okely John Okely
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.