Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51880

Minor issues with Atto's table setting

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.0
    • Fix Version/s: 3.0
    • Component/s: HTML Editor (Atto)
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as admin
      2. Make sure the table settings are enabled for the Atto plugin (including selecting all of the border style options)
        • site administration > plugins > text editors > atto html editor > table settings
      3. Go to a place with the Atto editor (e.g. the create course page)
      4. Add a table using Atto
        • Click the "show more buttons" button (top left) to reveal the table button
      5. Try adding and editing the table
      6. The things you should see:
        1. The border option should default to "Theme default"
        2. When "Theme default" is selected the other border options are disabled
        3. Default border style should be "Inherit"
        4. Setting "Theme default" should remove the inline styling of the table all together
        5. The default colour selection should be "Theme default" which, when selected, removes the inline colour styling
      Show
      Log in as admin Make sure the table settings are enabled for the Atto plugin (including selecting all of the border style options) site administration > plugins > text editors > atto html editor > table settings Go to a place with the Atto editor (e.g. the create course page) Add a table using Atto Click the "show more buttons" button (top left) to reveal the table button Try adding and editing the table The things you should see: The border option should default to "Theme default" When "Theme default" is selected the other border options are disabled Default border style should be "Inherit" Setting "Theme default" should remove the inline styling of the table all together The default colour selection should be "Theme default" which, when selected, removes the inline colour styling
    • Affected Branches:
      MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull Master Branch:
      MDL-51880-master

      Description

      1. Settings related to the border are lost when the setting 'Borders' is set to 'No border'. This should not happen - we should just ignore them but not reset them to default
      2. Why is there a 'Border style' of 'none'? Doesn't seem to do anything different than just choosing 'No border'.
      3. If you have a border set, but change the style to 'none' it then sets the border to 'No border' when you edit it again, then if you save it again all the settings are lost because the border value has been changed to 'No border' (related to point 1).
      4. If you enable a setting, such as background colour, create a table with a background colour, then disable the setting the table keeps the background colour - which is what I would expect. However, if you then edit this table the colour is lost and there is now no option to set it back.
      5. More experimentation with this setting may reveal other issues.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                13 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  16/Nov/15