Guest enrol password policies not always observed

Test 1 (master and 3.0 only) Ensure you have a password policy on your site ('Site administration' > 'Security' > 'Site policies'). Visit the settings for the guest enrolment plugin ('Site administration' > 'Plugins' > 'Enrolments' > 'Guest access') and ensure 'usepasswordpolicy' and 'requirepassword' are disabled (may want to keep this in another tab as you will be visiting this page again). Visit the 'Enrolment methods' page for a course ('Course administration' > 'Users' > 'Enrolment methods'). Add a 'Guest access' enrolment instance (if there currently is one delete it first). Set 'Allow guest access' to 'Yes' and the password '123' and ensure you can save successfully. Disable it via the eye icon on the 'Enrolment methods' page. Check that you can re-enable it via the eye icon. Visit the settings for the guest enrolment plugin and enable 'usepasswordpolicy' and ensure 'requirepassword' is disabled. Edit the 'Guest access' instance and set 'Allow guest access' to 'Yes' and leave the 'Password' as '123' (they should already be set to those values) and ensure you can save successfully. Disable it via the eye icon on the 'Enrolment methods' page. Check that you can not re-enable the guest instance via the eye icon. Edit the 'Guest access' instance and set 'Allow guest access' to 'Yes' and leave the 'Password' as '123' (the password should already be set to that value). Confirm that you get a warning saying the password does not meet the password policy. Set the password to empty. Ensure you can save the form. Disable it via the eye icon on the 'Enrolment methods' page. Check that you can re-enable it via the eye icon. Re-visit the settings for the guest enrolment plugin and enable 'requirepassword'. Edit the 'Guest access' instance and set 'Allow guest' to 'Yes' and leave the 'Password' empty (they should already be like that) and ensure you can save successfully. Disable it via the eye icon on the 'Enrolment methods' page. Check that you can not enable guest access via the eye icon. Edit the guest enrolment instance. Set 'Allow guest access' to 'Yes' and try to save without a password entered. Confirm that you get a warning saying the password is required. Enter a password that does not match the password policy. Confirm that you get a warning saying the password does not meet the password policy. Enter a password that does fit it and confirm you can save successfully. Edit the 'Guest access' instance. Set the 'Allow guest access' to 'No' and confirm that you can set the 'Password' to a password that does not meet the criteria and save successfully. Edit the 'Guest access' instance. Set the 'Allow guest access' to 'No' and confirm that you can set the 'Password' to empty and save successfully. Test 2 (2.9 only) Ensure you have a password policy on your site. Visit the settings for the guest enrolment plugin and ensure 'usepasswordpolicy' and 'requirepassword' are disabled (may want to keep this in another tab as you will be visiting this page again). Create a new course and set 'Allow guest access' to 'Yes' and add the password '123' - check there are no warnings. Visit the 'Enrolment methods' page for the course (may want to keep this in another tab as you will be visiting this page again). Disable the guest enrolment instance via the eye icon on the 'Enrolment methods' page. Check that you can re-enable it via the eye icon. Visit the settings for the guest enrolment plugin and enable 'usepasswordpolicy' and ensure 'requirepassword' is disabled. Edit the course and set 'Allow guest access' to 'Yes' and leave the 'Password' as '123' (they should already be set to those values) and ensure you can save successfully. Visit the 'Enrolment methods' page for the course. Disable it via the eye icon on the 'Enrolment methods' page. Check that you can not re-enable the guest instance via the eye icon. Visit the course settings and set 'Allow guest access' to 'Yes' and leave the password as it is. Check that when you save the form you are told the password does not meet the criteria. Set the password to empty. Check that you can now save it. Disable it via the eye icon on the 'Enrolment methods' page. Check that you can re-enable it via the eye icon. Visit the settings for the guest enrolment plugin and enable 'requirepassword'. Edit the course and set 'Allow guest access' to 'Yes' and leave the 'Password' empty (they should already be set to those values) and ensure you can save successfully. Visit the 'Enrolment methods' page for the course. Disable it via the eye icon on the 'Enrolment methods' page. Check that you can not re-enable the guest instance via the eye icon. Visit the settings page for the course and confirm that when you try to save the course with 'Allow guest access' set to 'Yes' and the password as empty you get a warning saying the password is required. Enter a password that does not match the password policy. Confirm that you get a warning saying the password does not meet the password policy. Enter a password that does fit it and confirm you can save successfully. Edit the course. Set the 'Password' to a password that does not meet the criteria and then set 'Allow guest access' to 'No' (have to do this after otherwise password field gets disabled) and save successfully. Edit the course. Set the 'Password' to empty and then set 'Allow guest access' to 'No' (have to do this after otherwise password field gets disabled) and save successfully.