Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51918

Grader report: AJAX keyboard navigation broken with editing turned on after MDL-36606

    XMLWordPrintable

Details

    • MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
    • MOODLE_28_STABLE, MOODLE_29_STABLE
    • MDL-51918-master-navigable
    • Hide

      In a course with multiple students and grade items, including at least one grade item set to type "text" (feedback only):

      • Enable AJAX in the Grader Report preferences
      • Ensure that quick feedback is DISABLED
      • View the grader report with editing mode OFF:
        • Click on a cell to edit it
        • Use ctrl+up/down/left/right to navigate between cells, confirm that you can reach all cells
      • Turn editing mode ON (in the grader report) and:
        • Focus a cell in the report
        • Use ctrl+up/down/left/right to navigate between cells, confirm that you can reach all cells
      Show
      In a course with multiple students and grade items, including at least one grade item set to type "text" (feedback only): Enable AJAX in the Grader Report preferences Ensure that quick feedback is DISABLED View the grader report with editing mode OFF : Click on a cell to edit it Use ctrl+up/down/left/right to navigate between cells, confirm that you can reach all cells Turn editing mode ON (in the grader report) and: Focus a cell in the report Use ctrl+up/down/left/right to navigate between cells, confirm that you can reach all cells

    Description

      MDL-36606 made changes to the AJAX grader report interface, which break the ctrl+left/right/up/down navigation when the gradebook is in editing mode.

      The patch introduced in MDL-36606 looks for a new "clickable" class, but only applies that class when editing mode is off - when editing mode is on, the keyboard navigation functions can't find any cells with the "clickable" class and thus cycle through the table and eventually spit out a JS error along the lines of "TypeError: this.current is null".

      The simplest fix is to move the logic which applies the "clickable" class to a location where it runs whether or not the gradebook is in editing mode, so that the class is applied (where appropriate) irrespective of whether editing mode is enabled.

      Attachments

        Issue Links

          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-36606 AJAX Grader report doesn't handle cells without an editable grade

          • Major - Major loss of function, incorrect output
          • Closed

          Activity

            People

              paul.n Paul Nicholls
              paul.n Paul Nicholls
              Eric Merrill Eric Merrill
              Andrew Lyons Andrew Lyons
              Simey Lameze Simey Lameze
              Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Nov/15