Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51935

Missing some error strings in mod/wiki

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9.2
    • Fix Version/s: 2.8.10, 2.9.4
    • Component/s: Wiki (2.x)
    • Labels:
    • Testing Instructions:
      Hide
      1. Add a wiki to your Moodle.
      2. Open the following URL and check that the error "Invalid parameters have been given" is shown.
        • YOURMOODLE/mod/wiki/view.php
      3. Now open the following URL using an invalid pageid and check that the error "Page ID is incorrect" is shown.
        • YOURMOODLE/mod/wiki/view.php?pageid=999
      4. Unfortunately, the other errors cannot be reproduced without manually modifying the database.
      5. Add a page to your wiki.
      6. Go to the table mdl_wiki_pages in the database, search for the page you just created and modify its subwikiid. Use a subwikiid that doesn't exist.
      7. Open the following URL using your pageid and check that the error "Subwiki ID is incorrect" is shown.
        • YOURMOODLE/mod/wiki/view.php?pageid=1
      8. Go back to the DB and leave the subwikiid value like it was.
      9. Now go to the table mdl_wiki_subwikis, search the subwiki your page belongs to and change its wikiid. Use a wikiid that doesn't exist.
      10. Open the following URL using your pageid and check that the error "Wiki ID is incorrect" is shown.
        • YOURMOODLE/mod/wiki/view.php?pageid=1
      11. Now open the following URL using the subwiki ID that you have changed. Check that the error "Wiki ID is incorrect" is shown.
        • YOURMOODLE/mod/wiki/create.php?swid=1
      12. Go back to the DB and leave the wikiid value like it was.
      13. Open the following URL using a valid pageid. Check that the error "A page version can only be compared with an older version." is shown.
        • YOURMOODLE/mod/wiki/diff.php?pageid=1&comparewith=1&compare=2
      Show
      Add a wiki to your Moodle. Open the following URL and check that the error " Invalid parameters have been given " is shown. YOURMOODLE/mod/wiki/view.php Now open the following URL using an invalid pageid and check that the error " Page ID is incorrect " is shown. YOURMOODLE/mod/wiki/view.php?pageid=999 Unfortunately, the other errors cannot be reproduced without manually modifying the database. Add a page to your wiki. Go to the table mdl_wiki_pages in the database, search for the page you just created and modify its subwikiid . Use a subwikiid that doesn't exist. Open the following URL using your pageid and check that the error " Subwiki ID is incorrect " is shown. YOURMOODLE/mod/wiki/view.php?pageid=1 Go back to the DB and leave the subwikiid value like it was. Now go to the table mdl_wiki_subwikis , search the subwiki your page belongs to and change its wikiid . Use a wikiid that doesn't exist. Open the following URL using your pageid and check that the error " Wiki ID is incorrect " is shown. YOURMOODLE/mod/wiki/view.php?pageid=1 Now open the following URL using the subwiki ID that you have changed. Check that the error " Wiki ID is incorrect " is shown. YOURMOODLE/mod/wiki/create.php?swid=1 Go back to the DB and leave the wikiid value like it was. Open the following URL using a valid pageid . Check that the error "A page version can only be compared with an older version." is shown. YOURMOODLE/mod/wiki/diff.php?pageid=1&comparewith=1&compare=2
    • Affected Branches:
      MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-51935-master

      Description

      In the wiki there are some errors used that doesn't exist. These are the ones I found:

      • incorrectpageid
      • incorrectsubwikiid
      • incorrectwikiid
      • incorrectparameters

      These are used throughout the module, and I wasn't able to find them in the language packs. They should be added.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Jan/16