Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51939

Forum post not visible to students when forum is separate groups and post is sent to all participants

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Test setup

      On the 27 and 28 branches only - before applying the patch (or with it reverted):

      1. Create a course with 1 group in it
      2. Create three forums in the course - one in each group mode
      3. Post some discussions in each forum:
        1. No groups - just post
        2. Separate groups - one post to 'All participants', one post to your group
        3. Visible groups - one post to 'All participants', one post to your group
          (you should have a total of five posts)
      4. Reply to each discussion
      5. Inspect the forum_discussions table in the database. You should see a groupid of 0 is present.
      6. As a student in the group:
        1. Confirm that you cannot see the discussions written to 'All participants'
      Testing instructions
      1. Run the Moodle upgrade
        1. Verify that the forum_discussions table no longer has groupid of 0. These should now all be -1
      2. Post and reply in all forums and groups again
        1. Verify that the forum_discussions table has no records with a groupid of 0
      3. As a student in the group:
        1. Confirm that you can see every discussion

      Note: For 29/master changes, you need to take a 28 site from last week's stable, and perform the upgrade. You will need bad data before each upgrade - e.g. 28 -> 29; and then a separate 28 -> master

      Show
      Test setup On the 27 and 28 branches only - before applying the patch (or with it reverted): Create a course with 1 group in it Create three forums in the course - one in each group mode Post some discussions in each forum: No groups - just post Separate groups - one post to 'All participants', one post to your group Visible groups - one post to 'All participants', one post to your group (you should have a total of five posts) Reply to each discussion Inspect the forum_discussions table in the database. You should see a groupid of 0 is present. As a student in the group: Confirm that you cannot see the discussions written to 'All participants' Testing instructions Run the Moodle upgrade Verify that the forum_discussions table no longer has groupid of 0. These should now all be -1 Post and reply in all forums and groups again Verify that the forum_discussions table has no records with a groupid of 0 As a student in the group: Confirm that you can see every discussion Note: For 29/master changes, you need to take a 28 site from last week's stable, and perform the upgrade. You will need bad data before each upgrade - e.g. 28 -> 29; and then a separate 28 -> master
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull Master Branch:
      MDL-51939-master

      Description

      When a forum is setup to use separate groups and a lecturer posts a discussion to the forum selecting to send to: 'All Participants' students are not able to view the post.

      This seems to be a regression caused by: MDL-50576 as it now sets the groupid for forum posts that are sent to all participants to 0 instead of -1.

      Steps to replicate:
      1. Create a course with two groups, one student, one teacher.
      2. Create a forum activity and set Group mode to 'Separate groups'
      3. As the teacher create a post, set Group to 'All participants' and check mail now.
      4. As the student view the forum post and the discussion cannot be seen.

      Patch developed will push through soon

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Nov/15