Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51991

Remove unnecessary Atto table settings for border styling

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. log in as admin
      2. Navigate to the atto table settings page (site administration > plugins > text editors > atto html editor > table settings)
      3. Make sure the language strings render correctly
      4. Make sure there is only one option for enabling / disabling the border styling
      5. Open the developer console and ensure there are no errors for the following steps
      6. Repeat testing from MDL-45515 (note that in this issue we simplified the existing border-related settings, so testing instructions might slightly differ)
      7. Repeat testing from MDL-51880 (note that in this issue we simplified the existing border-related settings, so testing instructions might slightly differ)
      Show
      log in as admin Navigate to the atto table settings page (site administration > plugins > text editors > atto html editor > table settings) Make sure the language strings render correctly Make sure there is only one option for enabling / disabling the border styling Open the developer console and ensure there are no errors for the following steps Repeat testing from MDL-45515 (note that in this issue we simplified the existing border-related settings, so testing instructions might slightly differ) Repeat testing from MDL-51880 (note that in this issue we simplified the existing border-related settings, so testing instructions might slightly differ)
    • Affected Branches:
      MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull Master Branch:
      MDL-51991-master

      Description

      As tried on http://qa.moodle.net:

      1. With atto_table | allowborders disabled, the table has dotted borders
      2. With atto_table | allowborders enabled, all options - theme default, around table, and around each cell give a table with no borders

      Expected result (based on admin settings lang strings):

      With atto_table | allowborders enabled, resulting in users having a setting named 'Borders', any table created with borders set to around table or around each cell should have solid, 1px, black borders.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              ryanwyllie Ryan Wyllie
              Reporter:
              tsala Helen Foster
              Peer reviewer:
              Dan Poltawski
              Integrator:
              David Monllaó
              Tester:
              Simey Lameze
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                16/Nov/15