Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-51991

Remove unnecessary Atto table settings for border styling

    XMLWordPrintable

Details

    • MOODLE_30_STABLE
    • MOODLE_30_STABLE
    • MDL-51991-master
    • Hide
      1. log in as admin
      2. Navigate to the atto table settings page (site administration > plugins > text editors > atto html editor > table settings)
      3. Make sure the language strings render correctly
      4. Make sure there is only one option for enabling / disabling the border styling
      5. Open the developer console and ensure there are no errors for the following steps
      6. Repeat testing from MDL-45515 (note that in this issue we simplified the existing border-related settings, so testing instructions might slightly differ)
      7. Repeat testing from MDL-51880 (note that in this issue we simplified the existing border-related settings, so testing instructions might slightly differ)
      Show
      log in as admin Navigate to the atto table settings page (site administration > plugins > text editors > atto html editor > table settings) Make sure the language strings render correctly Make sure there is only one option for enabling / disabling the border styling Open the developer console and ensure there are no errors for the following steps Repeat testing from MDL-45515 (note that in this issue we simplified the existing border-related settings, so testing instructions might slightly differ) Repeat testing from MDL-51880 (note that in this issue we simplified the existing border-related settings, so testing instructions might slightly differ)

    Description

      As tried on http://qa.moodle.net:

      1. With atto_table | allowborders disabled, the table has dotted borders
      2. With atto_table | allowborders enabled, all options - theme default, around table, and around each cell give a table with no borders

      Expected result (based on admin settings lang strings):

      With atto_table | allowborders enabled, resulting in users having a setting named 'Borders', any table created with borders set to around table or around each cell should have solid, 1px, black borders.

      Attachments

        1. admin_settings_1.png
          155 kB
          Ryan Wyllie
        2. admin_settings_2.png
          119 kB
          Ryan Wyllie
        3. border setting for user.png
          8 kB
          Helen Foster
        4. Table with allow borders disabled.png
          7 kB
          Helen Foster
        5. Table with around each cell border.png
          7 kB
          Helen Foster
        6. Table with around table border.png
          6 kB
          Helen Foster
        7. Table with theme default border.png
          6 kB
          Helen Foster

        Issue Links

          Activity

            People

              ryanwyllie Ryan Wyllie
              tsala Helen Foster
              Dan Poltawski Dan Poltawski
              David Monllaó David Monllaó
              Simey Lameze Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.