[MDL-51999] Wrong usage of continue in get_user_profile_fields() - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
Fixed Branches:
MOODLE_28_STABLE, MOODLE_29_STABLE
Epic Link:
Prepare Moodle for PHP7
Pull from Repository:
https://github.com/marinaglancy/moodle
Pull Master Branch:
wip-~~MDL-51999~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...marinaglancy:wip-MDL-51999-master
Testing Instructions:
Hide

Make sure you don't have any custom profile fields defined

View/edit user profile, there should not be any errors

Create custom profile field(s)

View/edit user profile, make sure custom profile fields appear
Show
Make sure you don't have any custom profile fields defined View/edit user profile, there should not be any errors Create custom profile field(s) View/edit user profile, make sure custom profile fields appear

One of the continue statements is used in get_user_profile_fields() function in grade/lib.php outside of a loop:

            if (!is_array($customfields)) {

                continue;

In PHP 7 this will cause fatal error:
Fatal error: 'continue' not in the 'loop' or 'switch' context in grade/lib.php on line 3147 (https://github.com/moodle/moodle/blob/master/grade/lib.php#L3146).

Participants:: CiBoT, Dan Poltawski, Eloy Lafuente (stronk7), John Okely, Marina Glancy, Tomasz Muras

Component watchers:: Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie