[MDL-52004] Atto autosave restores draft for wrong student when grading assignments - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 2.8.8, 2.9.2
Fix Version/s: 2.8.9, 2.9.3
Component/s: Text editor Atto
Labels:
- ci
- triaged

Affected Branches:
MOODLE_28_STABLE, MOODLE_29_STABLE
Fixed Branches:
MOODLE_28_STABLE, MOODLE_29_STABLE
Pull from Repository:
git://github.com/damyon/moodle.git
Pull Master Branch:
~~MDL-52004~~-master
Pull Master Diff URL:
https://github.com/damyon/moodle/compare/821ab27...MDL-52004-master
Testing Instructions:

Hide

In a course with 2 students create an assignment with feedback comments enabled.

Grade the first user in the list - enter some text in the feedback comments, but don't submit the form. Wait for the autosave to trigger then use the browser back button to go back to the grading table.
Use the sort options to resort the grading table so the second user is now first.
Click the grade link for the (now) first user in the table
Verify the draft text was NOT restored.

Click the next link to go to the second student
Verify the draft text was restored.

Show
In a course with 2 students create an assignment with feedback comments enabled. Grade the first user in the list - enter some text in the feedback comments, but don't submit the form. Wait for the autosave to trigger then use the browser back button to go back to the grading table. Use the sort options to resort the grading table so the second user is now first. Click the grade link for the (now) first user in the table Verify the draft text was NOT restored. Click the next link to go to the second student Verify the draft text was restored.

Description

We've run into an issue with Atto that stems from this. The rownum logic causes Atto to potentially load the wrong draft content into the feedback field when editing a grade. Because Atto loads the draft based on the value of $PAGE and the field name, the rownum logic is not unique enough.

Attachments

Issue Links

is duplicated by

MDL-52268 ATTO Editor not purge "not saved" draft

Closed

Activity

People

Assignee:: Damyon Wiese

Reporter:: Damyon Wiese

Peer reviewer:: cameron1729

Integrator:: Andrew Lyons

Tester:: Ryan Wyllie

Participants:: Andrew Lyons, cameron1729, CiBoT, Damyon Wiese, Dan Poltawski, Ryan Wyllie

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 02/Nov/15 9:02 PM

Updated:: 11/Dec/15 6:54 PM

Resolved:: 07/Nov/15 6:50 AM

Fix Release Date:: 9/Nov/15