Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52004

Atto autosave restores draft for wrong student when grading assignments

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      In a course with 2 students create an assignment with feedback comments enabled.

      Grade the first user in the list - enter some text in the feedback comments, but don't submit the form. Wait for the autosave to trigger then use the browser back button to go back to the grading table.
      Use the sort options to resort the grading table so the second user is now first.
      Click the grade link for the (now) first user in the table
      Verify the draft text was NOT restored.

      Click the next link to go to the second student
      Verify the draft text was restored.

      Show
      In a course with 2 students create an assignment with feedback comments enabled. Grade the first user in the list - enter some text in the feedback comments, but don't submit the form. Wait for the autosave to trigger then use the browser back button to go back to the grading table. Use the sort options to resort the grading table so the second user is now first. Click the grade link for the (now) first user in the table Verify the draft text was NOT restored. Click the next link to go to the second student Verify the draft text was restored.
    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-52004-master

      Description

      From a comment on MDL-44330

      We've run into an issue with Atto that stems from this. The rownum logic causes Atto to potentially load the wrong draft content into the feedback field when editing a grade. Because Atto loads the draft based on the value of $PAGE and the field name, the rownum logic is not unique enough.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Nov/15