[MDL-52014] When quiz previews are deleted automatically, that should not be logged as attempt deleted - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.8.8, 2.9.2, 3.0
Fix Version/s: 2.8.9, 2.9.3
Component/s: Events API, Quiz
Labels:
- ci
- triaged

Affected Branches:
MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
Fixed Branches:
MOODLE_28_STABLE, MOODLE_29_STABLE
Pull from Repository:
git://github.com/danpoltawski/moodle.git
Pull Master Branch:
~~MDL-52014~~-master
Pull Master Diff URL:
https://github.com/danpoltawski/moodle/compare/821ab27...MDL-52014-master
Testing Instructions:
Hide

At teacher

Create a new quiz with one essay question

Preview the quiz, and submit your preview attempt

Edit the quiz and add a new multiple choice question

View the course logs

VERIFY there is no 'Quiz attempt deleted' log entry against the teacher
Show
At teacher Create a new quiz with one essay question Preview the quiz, and submit your preview attempt Edit the quiz and add a new multiple choice question View the course logs VERIFY there is no 'Quiz attempt deleted' log entry against the teacher

Description

The quiz_delete_attempt method in mod/quiz/locallib.php should only log the attempt_deleted event if the attempt is not a preview (Only log is $attempt->preview is 0).

Attachments

Issue Links

is a regression caused by

MDL-40063 Replace add_to_log with an event trigger - mod_quiz

Closed

Activity

People

Assignee:: Dan Poltawski

Reporter:: Tim Hunt

Peer reviewer:: Tim Hunt

Integrator:: Eloy Lafuente (stronk7)

Tester:: Simey Lameze

Participants:: CiBoT, Dan Poltawski, Eloy Lafuente (stronk7), Simey Lameze, Tim Hunt

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Tim Hunt, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 03/Nov/15 4:49 AM

Updated:: 04/Nov/15 2:34 PM

Resolved:: 04/Nov/15 2:34 PM

Fix Release Date:: 9/Nov/15