Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52081

Use proper __construct in forms API for PHP7 support

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.0
    • Fix Version/s: 3.0.1
    • Component/s: Forms Library
    • Labels:
    • Testing Instructions:
      Hide

      The following forms need to be checked that they don't throw any errors/debugging messages:

      • user edit form
      • course edit form
      • event monitor report
      • add assignment form
      • add lesson form
      • upload users form
      • create assignment with rubric
      • grade student in assignment with rubric
      • test file with otherwise unused element(s): htmleditor, listing, warning, submitlink https://gist.github.com/marinaglancy/8c9071a5cbd7bd198b4f
      • community block search form
      • edit question categories (in question bank inside a course)
      • create wiki without forcing page format and add pages
      • enable self registration and recaptcha and check out registration form with recaptcha el
      • create lesson and select user override (searchableselector element)
      • enable outcomes and edit outcome (/grade/edit/outcome/edit.php)
      • create database with several fields and open export form
      • register external blog form
      • create assignment with marking guide, define it and grade a student
      • create wiki and create a page in format other than html
      Show
      The following forms need to be checked that they don't throw any errors/debugging messages: user edit form course edit form event monitor report add assignment form add lesson form upload users form create assignment with rubric grade student in assignment with rubric test file with otherwise unused element(s): htmleditor, listing, warning, submitlink https://gist.github.com/marinaglancy/8c9071a5cbd7bd198b4f community block search form edit question categories (in question bank inside a course) create wiki without forcing page format and add pages enable self registration and recaptcha and check out registration form with recaptcha el create lesson and select user override (searchableselector element) enable outcomes and edit outcome (/grade/edit/outcome/edit.php) create database with several fields and open export form register external blog form create assignment with marking guide, define it and grade a student create wiki and create a page in format other than html
    • Affected Branches:
      MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull Master Branch:
      wip-MDL-52081-master

      Description

      in forms API we use class name as constructor, should be __construct()

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              marina Marina Glancy
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              cameron1729
              Integrator:
              David Monllaó
              Tester:
              Mark Nelson
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              1 Vote for this issue
              Watchers:
              10 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                21/Dec/15