Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52086

Subtree incorrectly rendered in renderer_base.render_tabobject()

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.11, 2.8.9, 2.9.3, 3.0
    • Fix Version/s: 2.9.4, 3.0.1
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide

      (While the "tabs" feature is used in core, namely in the gradebook, it's not used in a way which makes this bug surface. Therefore I think it's easiest to test this issue with a contributed plugin that uses the feature.)

      Prerequisites:

      • Install the "mod_scheduler" plugin in the appropriate version (for master, use Scheduler 2.9.0 from the plugins DB)
      • In "Site administration -> Grades -> General settings", set "Navigation method" to "Tabs"
      • In "Theme settings", activate "Allow theme changes in the URL"
      • Create a course (C)
      • Create one editing teacher (T) in the course C
      • Create a scheduler activity in the course C

      Test case:

      • Log in as T
      • Change to the "base" theme (http://<yourmoodlesite>/?theme=base)
      • Go to C, then to the scheduler activity created above
      • VERIFY: Only one row of tabs is shown (My appointments, All appointments, Overview, Statistics, Export)
      • Click on "Statistics"
      • VERIFY: Two rows of tabs are shown
      • Click on "Export"
      • VERIFY: Only one row of tabs is shown
      • Click on "Course administration -> Grades"
      • VERIFY: Two rows of tabs are shown ("View, Setup, Scales,..." and "Grader report, Grade history...")
      • Click on "Scales"
      • VERIFY: Only one row of tabs is shown, with the row below just containing the word "View".
      Show
      (While the "tabs" feature is used in core, namely in the gradebook, it's not used in a way which makes this bug surface. Therefore I think it's easiest to test this issue with a contributed plugin that uses the feature.) Prerequisites: Install the "mod_scheduler" plugin in the appropriate version (for master, use Scheduler 2.9.0 from the plugins DB) In "Site administration -> Grades -> General settings", set "Navigation method" to "Tabs" In "Theme settings", activate "Allow theme changes in the URL" Create a course (C) Create one editing teacher (T) in the course C Create a scheduler activity in the course C Test case: Log in as T Change to the "base" theme (http://<yourmoodlesite>/?theme=base) Go to C, then to the scheduler activity created above VERIFY: Only one row of tabs is shown (My appointments, All appointments, Overview, Statistics, Export) Click on "Statistics" VERIFY: Two rows of tabs are shown Click on "Export" VERIFY: Only one row of tabs is shown Click on "Course administration -> Grades" VERIFY: Two rows of tabs are shown ("View, Setup, Scales,..." and "Grader report, Grade history...") Click on "Scales" VERIFY: Only one row of tabs is shown, with the row below just containing the word "View".
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull Master Branch:

      Description

      The core output renderers provide a feature for rendering a "hierarchical" tab navigation. That is, the user sees a list of "tabs" to click on; clicking on one of them, the user may then see a second row of tabs from which they can choose.

      Expected behaviour: The second row of tabs is shown only when a selection from the first row has been made, and only for the "subtree" related to the tab from the first row that has been selected.

      There is currently a bug in the core renderer by which the second row of tabs is always displayed, independent of what is selected from the first row.

      Note that this affects only themes that are directly derived from "base" or "canvas". The "bootstrapbase" theme overrides the core renderer and replaces it with the correct behaviour. In particular, the bug does not occur with the "Clean" and "More" themes.

      See CONTRIB-5981 for further details.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  21/Dec/15