Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52141

Log restore alters log input row so it can't be processed correctly by future rules

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9.3
    • Fix Version/s: 2.9.4, 3.0.1
    • Component/s: Backup
    • Labels:

      Description

      During a restore, the log process script uses the input parameter $log as the target for data from the log processing.

      If there is an attempt to process a log record and a problem is found, the $log is altered but the function returns false. The parent function then loops to the next rules to see if it can be successfully decoded. However by this time the $log is invalid and no other rules will match.

        Attachments

        1. 0001-MDL-52141-backup-test-restore_log_rule-don-t-modify-.patch
          3 kB
          Eloy Lafuente (stronk7)
        2. backup-test-with-course-logs.mbz
          782 kB
          Jun Pataleta
        3. backup-test-without-course-logs.mbz
          780 kB
          Jun Pataleta
        4. integration_master.png
          51 kB
          Jun Pataleta
        5. original_logs.png
          74 kB
          Jun Pataleta
        6. stable_master_after_original_patch.png
          101 kB
          Jun Pataleta

          Issue Links

            Activity

              People

              Assignee:
              mr-russ Russell Smith
              Reporter:
              mr-russ Russell Smith
              Peer reviewer:
              Adrian Greeve
              Integrator:
              Dan Poltawski
              Tester:
              Jun Pataleta
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                21/Dec/15