Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52180

Travis: Remove 'Current commit is based on an older weekly release'

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0
    • Fix Version/s: 2.9.4, 3.0.1
    • Component/s: Unit tests
    • Labels:
    • Testing Instructions:
      Hide

      To simulate this previously causing a problem would be a fakely simulated pain and not worth the effort IMO.

      I propose to just do a regression test:

      • Setup travis integration on your github clone
      • Push a branch changing a comment
      • Ensure the travis run passes
      Show
      To simulate this previously causing a problem would be a fakely simulated pain and not worth the effort IMO. I propose to just do a regression test: Setup travis integration on your github clone Push a branch changing a comment Ensure the travis run passes
    • Affected Branches:
      MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull Master Branch:
      MDL-52180-master

      Description

      I do not think its good to have the 'older weekly release' check on travis, having seen it on one of my commits .

      The reasoning:

      • It increases 'false positives' which makes the check less useful - I noticed this because I look at the ticks and crosses
      • Cibot does it for integration, no need to duplicate it here - its only relevant to actual issues sent to integration
      • CiBot is much more tolerant (60 days for error, 14 for warn)
      • It makes the travis config less useful for people not intending to immediately merge into moodle.git

        Attachments

          Activity

            People

            • Assignee:
              poltawski Dan Poltawski
              Reporter:
              poltawski Dan Poltawski
              Peer reviewer:
              Andrew Nicols
              Integrator:
              David Monllaó
              Tester:
              Jun Pataleta
              Participants:
              Component watchers:
              Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                21/Dec/15