Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52180

Travis: Remove 'Current commit is based on an older weekly release'

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.0
    • 2.9.4, 3.0.1
    • Unit tests
    • MOODLE_30_STABLE
    • MOODLE_29_STABLE, MOODLE_30_STABLE
    • MDL-52180-master
    • Hide

      To simulate this previously causing a problem would be a fakely simulated pain and not worth the effort IMO.

      I propose to just do a regression test:

      • Setup travis integration on your github clone
      • Push a branch changing a comment
      • Ensure the travis run passes
      Show
      To simulate this previously causing a problem would be a fakely simulated pain and not worth the effort IMO. I propose to just do a regression test: Setup travis integration on your github clone Push a branch changing a comment Ensure the travis run passes

    Description

      I do not think its good to have the 'older weekly release' check on travis, having seen it on one of my commits .

      The reasoning:

      • It increases 'false positives' which makes the check less useful - I noticed this because I look at the ticks and crosses
      • Cibot does it for integration, no need to duplicate it here - its only relevant to actual issues sent to integration
      • CiBot is much more tolerant (60 days for error, 14 for warn)
      • It makes the travis config less useful for people not intending to immediately merge into moodle.git

      Attachments

        Activity

          People

            poltawski Dan Poltawski
            poltawski Dan Poltawski
            Andrew Lyons Andrew Lyons
            David Monllaó David Monllaó
            Jun Pataleta Jun Pataleta
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              21/Dec/15