Loading...

XML

Word

Printable

Affected Branches:
MOODLE_30_STABLE
Fixed Branches:
MOODLE_29_STABLE, MOODLE_30_STABLE
Pull from Repository:
git://github.com/danpoltawski/moodle.git
Pull Main Branch:
~~MDL-52180~~-master
Pull Main Diff URL:
https://github.com/danpoltawski/moodle/compare/26653c8...MDL-52180-master
Testing Instructions:
Hide

To simulate this previously causing a problem would be a fakely simulated pain and not worth the effort IMO.

I propose to just do a regression test:

Setup travis integration on your github clone

Push a branch changing a comment

Ensure the travis run passes
Show
To simulate this previously causing a problem would be a fakely simulated pain and not worth the effort IMO. I propose to just do a regression test: Setup travis integration on your github clone Push a branch changing a comment Ensure the travis run passes

I do not think its good to have the 'older weekly release' check on travis, having seen it on one of my commits .

The reasoning:

It increases 'false positives' which makes the check less useful - I noticed this because I look at the ticks and crosses
Cibot does it for integration, no need to duplicate it here - its only relevant to actual issues sent to integration
CiBot is much more tolerant (60 days for error, 14 for warn)
It makes the travis config less useful for people not intending to immediately merge into moodle.git

Participants:: Andrew Lyons, CiBoT, Dan Poltawski, David Monllaó, Jun Pataleta