-
Bug
-
Resolution: Fixed
-
Critical
-
2.9.3, 3.0, 3.1
-
MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE
-
MOODLE_29_STABLE, MOODLE_30_STABLE
-
MDL-52204-master -
After creating the MOODLE_30_STABLE, suddenly grunt build started to fail in the public CI server. And both 29_STABLE and master, some days later, came to the same behavior.
The key difference is that, in that server, because of the npm version installed, the package 2.9.1rc1 of jshint was being installed, instead of the latest stable 2.8.0, that is normally installed elsewhere.
Such 2.9.1rc1 was release some days ago (also note that 2.9.0 was revoked because of some serious problems) and it includes some change to the "latedef" checks:
https://github.com/jshint/jshint/releases
So, although we are now back to the "correct" 2.8.0 version in the public CI servers and they have started to pass the grunt job... it would be great to know if the problems reported by 2.9.1rc1 are legit or no, because for sure we'll face them once 2.9.1 is released (if they are legit).
This are the current failures with 2.9.1rc1, FYI:
>> Shifter build complete.
|
|
Running "jshint:files" (jshint) task
|
|
lib/amd/src/form-autocomplete.js
|
375 | var updateSelectionList = function(options, state, originalSelect) {
|
^ 'updateSelectionList' was used before it was defined.
|
lib/amd/src/templates.js
|
103 | var partialHelper = function(name) {
|
^ 'partialHelper' was used before it was defined.
|
283 | var getTemplate = function(templateName, async) {
|
^ 'getTemplate' was used before it was defined.
|
|
>> 3 errors in 19 files
|
Warning: Task "jshint:files" failed. Use --force to continue.
|
Ciao
- blocks
-
MDL-52250 Updating npm dependencies and move to shrinkwrap to finally actually fix versions
-
- Closed
-
- Discovered while testing
-
MDL-51582 Switch to grunt to compile LESS as recess is no longer maintained
-
- Closed
-
- is blocked by
-
MDL-51582 Switch to grunt to compile LESS as recess is no longer maintained
-
- Closed
-