Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52206

Move "Require passing grade" completion option to core

    XMLWordPrintable

Details

    • MOODLE_29_STABLE, MOODLE_31_STABLE, MOODLE_33_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • MDL-52206-master-rebased
    • Hide

      Confirm behat and unit tests pass.

      Behat test provided.

      Before upgrade:

      Setup before upgrade - Requires db access:

      1. Install a moodle site based on the the latest weekly

        git checkout 70073fdc74fa8dda31512c01196aaa4e2f1266d4

      2. Restore the course - backup-moodle2-course-52-c1_1-20210630-1158.mbz
      3. Enrol 2 students to the course
      4. As a student, attempt the quiz activity (Note the state of the activity completion)

      Upgrade Test:

      1. Checkout master

        git checkout master

      2. Upgrade the site
        1. CLI

           sudo -u apache /usr/bin/php admin/cli/upgrade.php 

        2. Via browser as admin
      3. Confirm no issues during upgrade
      4. Go to the course created earlier
      5. Go to the assignment and edit it's settings
      6. Confirm the completion criteria is still set as before
      7. Go to the quiz and edit it's settings
      8. Repeat #6
      9. Go to your db and confirm the following:
        1. For the quiz:
          1. The quiz table does not have a completionpass column
          2. The corresponding course_module record has completionpassgrade set to 1
          3. completiongradeitemnumber is not null
        2. For the assignment
          1. The corresponding course_module record has completionpassgrade set to 0
          2. completiongradeitemnumber is not null
      10. Log in as the student who completed the quiz
      11. Confirm the activity completion is the same

      Manual feature testing (SCORM only):

      Behat tests cover the rest of the activities.

      1. Go to the course restored previously
      2. Turn on editing
      3. Add a SCORM activity
      4. In the setting,
      5. Open 'Activity completion'
      6. Confirm there is no 'Require passing grade' checkbox
      7. Add the SCORM package attached
      8. Click Save button
      9. Confirm there are no issues

      Backup and Restore:

      1. Contd from previous test,
      2. Go to the course created previously
      3. Initiate backup of an activity via the course admin menu (https://docs.moodle.org/39/en/Course_backup)
      4. Continue through all the backup steps using default settings
      5. Once the backup is completed click on the continue button
      6. Once on the 'Restore course' page, click the restore link against the file in the 'Course backup area'
      7. Restore the file into the existing course
      8. Once the restore process is completed, go to the restored activity
      9. Edit the settings
      10. confirm the 'Activity completion' criteria matches the original activity.

      Legacy backup and restore of quiz :

      1. On an install with the patch
      2. Login as admin
      3. Go to Site Administration > Course > Restore course
      4. Upload the backup-moodle2-course-52-c1_1-20210630-1158.mbz
      5. Continue through the restore process with the default settings.
      6. Once completed go to the restored quiz
      7. Confirm the quiz settings matches up with the following:
        1. Confirm Completion tracking - Show activity as complete when conditions are met
        2. Confirm Student must receive a grade to complete this activity - Checked
        3. Confirm Student must receive a passing grade to complete this activity - Checked
      Show
      Confirm behat and unit tests pass. Behat test provided. Before upgrade: Setup before upgrade - Requires db access: Install a moodle site based on the the latest weekly git checkout 70073fdc74fa8dda31512c01196aaa4e2f1266d4 Restore the course -  backup-moodle2-course-52-c1_1-20210630-1158.mbz Enrol 2 students to the course As a student, attempt the quiz activity (Note the state of the activity completion) Upgrade Test: Checkout master git checkout master Upgrade the site CLI sudo -u apache /usr/bin/php admin/cli/upgrade.php Via browser as admin Confirm no issues during upgrade Go to the course created earlier Go to the assignment and edit it's settings Confirm the completion criteria is still set as before Go to the quiz and edit it's settings Repeat #6 Go to your db and confirm the following: For the quiz: The quiz table does not have a completionpass column The corresponding course_module record has completionpassgrade set to 1 completiongradeitemnumber is not null For the assignment The corresponding course_module record has completionpassgrade set to 0 completiongradeitemnumber is not null Log in as the student who completed the quiz Confirm the activity completion is the same Manual feature testing (SCORM only): Behat tests cover the rest of the activities. Go to the course restored previously Turn on editing Add a SCORM activity In the setting, Open 'Activity completion' Confirm there is no 'Require passing grade' checkbox Add the SCORM package attached Click Save button Confirm there are no issues Backup and Restore: Contd from previous test, Go to the course created previously Initiate backup of an activity via the course admin menu ( https://docs.moodle.org/39/en/Course_backup ) Continue through all the backup steps using default settings Once the backup is completed click on the continue button Once on the 'Restore course' page, click the restore link against the file in the 'Course backup area' Restore the file into the existing course Once the restore process is completed, go to the restored activity Edit the settings confirm the 'Activity completion' criteria matches the original activity. Legacy backup and restore of quiz : On an install with the patch Login as admin Go to Site Administration > Course > Restore course Upload the  backup-moodle2-course-52-c1_1-20210630-1158.mbz Continue through the restore process with the default settings. Once completed go to the restored quiz Confirm the quiz settings matches up with the following: Confirm Completion tracking - Show activity as complete when conditions are met Confirm Student must receive a grade to complete this activity - Checked Confirm Student must receive a passing grade to complete this activity - Checked
    • 3
    • Activity Sprint 2, Activity Sprint 7, Activity Sprint 8, Activity Sprint 9, 4.0 holding pattern 3, 4.0 holding pattern 4, 4.0 holding pattern 5, 4.0 holding pattern 6, 4.0 holding pattern 12, 4.0 Navigation blitz, 4.0 Navigation blitz 2, QA blitz 3, Navigation push ahead

    Description

      Allow all core modules to have the ability to set a completion criteria of 'Require passing grade' similar to how quiz currently does.

      Original description -
      Administration > Site administration > Advanced features check the "Enable completion tracking" box.
      Administration > Course administration > Edit settings and enable the "Completion tracking section".
      Add an assignment > Set a passing grade for the assignment.
      Activity completion (of the assignment) > I CAN'T SEE THE OPTION "REQUIRE PASSING GRADE".

      ... And I need it, please
      Actually, the best option I can choose is "Students must receive a grade to complete this activity". But in this case, passed and no-passed assignments are marked as "completed".

      Attachments

        1. assignment_update.png
          assignment_update.png
          100 kB
        2. backup-moodle2-course-52-c1_1-20210630-1158.mbz
          54 kB
        3. completionprogressdetails.png
          completionprogressdetails.png
          60 kB
        4. current_failed_receiveagrade.png
          current_failed_receiveagrade.png
          33 kB
        5. expected_failed_receiveagrade.png
          expected_failed_receiveagrade.png
          32 kB
        6. image-2017-06-01-12-33-58-535.png
          image-2017-06-01-12-33-58-535.png
          5 kB
        7. image-2017-06-01-12-34-33-894.png
          image-2017-06-01-12-34-33-894.png
          2 kB
        8. image-2018-05-28-17-05-39-536.png
          image-2018-05-28-17-05-39-536.png
          7 kB
        9. image-2018-06-01-12-01-26-556.png
          image-2018-06-01-12-01-26-556.png
          9 kB
        10. image-2020-01-24-13-29-37-351.png
          image-2020-01-24-13-29-37-351.png
          52 kB
        11. MDL-52206_Backup and Restore.png
          MDL-52206_Backup and Restore.png
          101 kB
        12. MDL-52206_Before upgrade_Assignment.png
          MDL-52206_Before upgrade_Assignment.png
          85 kB
        13. MDL-52206_Before upgrade_Quiz.png
          MDL-52206_Before upgrade_Quiz.png
          100 kB
        14. MDL-52206_Legacy backup and restore of quiz.png
          MDL-52206_Legacy backup and restore of quiz.png
          135 kB
        15. MDL-52206_Manual feature testing_Step 6.png
          MDL-52206_Manual feature testing_Step 6.png
          140 kB
        16. MDL-52206_Manual feature testing_Step 9.png
          MDL-52206_Manual feature testing_Step 9.png
          87 kB
        17. MDL-52206_Upgrade Retest_Step 11 - Assignment.png
          MDL-52206_Upgrade Retest_Step 11 - Assignment.png
          88 kB
        18. MDL-52206_Upgrade Retest_Step 6.png
          MDL-52206_Upgrade Retest_Step 6.png
          88 kB
        19. MDL-52206_Upgrade Retest_Step 9_Assignment.png
          MDL-52206_Upgrade Retest_Step 9_Assignment.png
          57 kB
        20. MDL-52206_Upgrade Test_Step 11_Assignment.jpg
          MDL-52206_Upgrade Test_Step 11_Assignment.jpg
          31 kB
        21. MDL-52206_Upgrade Test_Step 11_Quiz.png
          MDL-52206_Upgrade Test_Step 11_Quiz.png
          100 kB
        22. MDL-52206_Upgrade Test_Step 3.png
          MDL-52206_Upgrade Test_Step 3.png
          105 kB
        23. MDL-52206_Upgrade Test_Step 6.jpg
          MDL-52206_Upgrade Test_Step 6.jpg
          31 kB
        24. MDL-52206_Upgrade Test_Step 8.png
          MDL-52206_Upgrade Test_Step 8.png
          100 kB
        25. MDL-52206_Upgrade Test_Step 9_Assignment.png
          MDL-52206_Upgrade Test_Step 9_Assignment.png
          58 kB
        26. MDL-52206_Upgrade Test_Step 9_Quiz_1.png
          MDL-52206_Upgrade Test_Step 9_Quiz_1.png
          236 kB
        27. MDL-52206_Upgrade Test_Step 9_Quiz_2-3.png
          MDL-52206_Upgrade Test_Step 9_Quiz_2-3.png
          58 kB
        28. MDL-52206-Assignment_require_passing_grade_activity_completion_testing.png
          MDL-52206-Assignment_require_passing_grade_activity_completion_testing.png
          136 kB
        29. MDL-52206-Assignment_require_passing_grade_activity_completion_UI.png
          MDL-52206-Assignment_require_passing_grade_activity_completion_UI.png
          148 kB
        30. quizerror.png
          quizerror.png
          56 kB
        31. RuntimeMinimumCalls_SCORM12-mini.zip
          209 kB
        32. Screenshot from 2020-08-14 15-56-15.png
          Screenshot from 2020-08-14 15-56-15.png
          51 kB
        33. Screenshot from 2020-08-14 15-57-33.png
          Screenshot from 2020-08-14 15-57-33.png
          53 kB

        Issue Links

          Activity

            People

              peterdias Peter Dias
              giugiupir giulia
              Jake Dallimore Jake Dallimore
              Ilya Tregubov Ilya Tregubov
              Angelia Dela Cruz Angelia Dela Cruz
              Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona), Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan, Tim Hunt, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo
              Votes:
              77 Vote for this issue
              Watchers:
              62 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                19/Apr/22

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 weeks, 2 hours, 56 minutes
                  2w 2h 56m