From Petr Skoda (skodak at centrum.cz) Tuesday, 18 April 2006, 05:22 AM:
I am not using flash or mediaplugin myself, you will have to assign it to somebody else
I guess you might try Jamie Pratt...
From Joseph R?zeau (joseph.rezeau at uhb.fr) Tuesday, 18 April 2006, 05:39 AM:
Martin, could you re-assign this bug please?
From Martin Dougiamas (martin at moodle.com) Thursday, 20 April 2006, 04:26 PM:
It might fix your problem, but does it cause more problems with different input?
What is the exact case you are using there?
I've checked this into CVS on the assumption you're right, but this might need more testing.
From Joseph R?zeau (joseph.rezeau at uhb.fr) Friday, 21 April 2006, 12:35 AM:
>It might fix your problem, but does it cause more problems with different input?
Well, I don't think there is another input going through there...
>What is the exact case you are using there?
Sorry, what do you mean by case ? UPPERCASE vs lower case?
Anyway, I have tested this bug again, and I can confirm that it has been there since at least version 1.5. In fact, NO CHANGES take place at all in the colors of the Flash player!!! This is because the faulty call to htmlentities changes the correct string, e.g.
into this garbage:
And I suspect that this bug has gone un-noticed all those years simply because no-one has ever taken the trouble to change the colors of the Flash player! I've noticed that ALL the themes which are currently distributed with Moodle simply copy exactly the same parameters as those from \filter\mediaplugin\filter.php. And it also goes un-noticed because the colors coded in filter.php are the same as those hard-coded in the Flash file! (i.e. black and green).
So I recommend deleting the faulty line
$c = htmlentities($c);
so everything works as expected.
From Martin Dougiamas (martin at moodle.com) Friday, 21 April 2006, 12:26 PM:
OK, great, thanks for the thining on this, fixed in 1.5.x and HEAD