Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52250

Updating npm dependencies and move to shrinkwrap to finally actually fix versions

    XMLWordPrintable

Details

    • MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE
    • MOODLE_29_STABLE, MOODLE_30_STABLE
    • MDL-52250-master
    • Hide

      Before starting:
      Have an non-updated moodle instance with all npm depdencies installed.

      1. Update your instance
      2. Run npm install
      3. Run grunt
      4. Verify no built files are changed
      5. Run npm outdated
      6. Verify no outdated packages are listed
      7. rm -R node_modules
      8. Run npm install
      9. Run grunt
      10. Verify no built files are changed

      Bonus test:

      1. rm -R node_modules rm npm-shrinkwrap.json
      2. npm install
      3. npm shrinkwrap --dev
      4. Compare the differences in the shrinkwrap (they should be minimal because we have very fixed package.json)

      Please read https://docs.moodle.org/dev/NPM#Updating_npm_dependencies and see if it would make sense to you for a future issue.

      Show
      Before starting: Have an non-updated moodle instance with all npm depdencies installed. Update your instance Run npm install Run grunt Verify no built files are changed Run npm outdated Verify no outdated packages are listed rm -R node_modules Run npm install Run grunt Verify no built files are changed Bonus test: rm -R node_modules rm npm-shrinkwrap.json npm install npm shrinkwrap --dev Compare the differences in the shrinkwrap (they should be minimal because we have very fixed package.json) Please read https://docs.moodle.org/dev/NPM#Updating_npm_dependencies and see if it would make sense to you for a future issue.

    Description

      While looking for some problems in the CI servers related to grunt ending with incorrect jshint installed, I did see that some of our devDependencies @ package.json are already slightly outdated.

      Specially it called my attention the existence of grunt-contrib-jshint 0.11.3 which release notes say they add support for jshint 2.8.0 (that is the one normally installed right now). Later I looked also to grunt-contrib-uglify and found it had evolved lately.

      Maybe we should consider bumping them @ regular basis, maybe only master, maybe all supported branches.

      For your consideration, ciao

      Attachments

        Issue Links

          Activity

            People

              poltawski Dan Poltawski
              stronk7 Eloy Lafuente (stronk7)
              David Mudrák (@mudrd8mz) David Mudrák (@mudrd8mz)
              Andrew Lyons Andrew Lyons
              Rajesh Taneja Rajesh Taneja
              Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona), Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                11/Jan/16