[MDL-52332] core\plugininfo\calendartype::load_settings() has invalid declaration - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.9.3, 3.0
Fix Version/s: 2.9.4, 3.0.1
Component/s: Calendar
Labels:
- ci
- regression
- triaged

Affected Branches:
MOODLE_29_STABLE, MOODLE_30_STABLE
Fixed Branches:
MOODLE_29_STABLE, MOODLE_30_STABLE
Epic Link:
Prepare Moodle for PHP7
Pull from Repository:
git://github.com/marinaglancy/moodle.git
Pull Main Branch:
~~MDL-52332~~-master
Pull Main Diff URL:
https://github.com/marinaglancy/moodle/compare/c18acb8...MDL-52332-master
Testing Instructions:

Hide

on master: Repeat testing instructions from ~~MDL-43008~~

on stables there is no functional change and really no need to do manual testing but you can install a calendar type just to double check.

Show
on master: Repeat testing instructions from MDL-43008 on stables there is no functional change and really no need to do manual testing but you can install a calendar type just to double check.

Description

This cause unittest failure on php7. But also the declaration of the function is simply illegal and it would throw an exception if it was ever called. But it is not. Which is another bug.

1) core_test_generator_testcase::test_create_module

Declaration of core\plugininfo\calendartype::load_settings(core\plugininfo\part_of_admin_tree $adminroot, $parentnodename, $hassiteconfig) should be compatible with core\plugininfo\base::load_settings(part_of_admin_tree $adminroot, $parentnodename, $hassiteconfig)

/Users/danp/moodles/im/moodle/lib/classes/plugininfo/calendartype.php:72

/Users/danp/moodles/im/moodle/lib/classes/component.php:96

/Users/danp/moodles/im/moodle/lib/classes/component.php:96

/Users/danp/moodles/im/moodle/lib/classes/plugin_manager.php:476

/Users/danp/moodles/im/moodle/lib/classes/plugin_manager.php:265

/Users/danp/moodles/im/moodle/lib/classes/plugin_manager.php:286

/Users/danp/moodles/im/moodle/availability/classes/tree.php:197

/Users/danp/moodles/im/moodle/course/modlib.php:90

/Users/danp/moodles/im/moodle/lib/testing/generator/module_generator.php:262

/Users/danp/moodles/im/moodle/mod/assign/tests/generator/lib.php:59

/Users/danp/moodles/im/moodle/lib/testing/generator/data_generator.php:480

/Users/danp/moodles/im/moodle/lib/testing/tests/generator_test.php:295

/Users/danp/moodles/im/moodle/lib/phpunit/classes/advanced_testcase.php:80

To re-run:

 vendor/bin/phpunit core_test_generator_testcase lib/testing/tests/generator_test.php

Attachments

Issue Links

is a regression caused by

MDL-43008 Calendar plugins can not display setting pages.

Closed

Activity

People

Assignee:: Marina Glancy

Reporter:: Marina Glancy

Peer reviewer:: Ryan Wyllie

Integrator:: Dan Poltawski

Tester:: Frédéric Massart

Participants:: CiBoT, Dan Poltawski, Eloy Lafuente (stronk7), Frédéric Massart, Marina Glancy, Ryan Wyllie

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 27/Nov/15 4:46 PM

Updated:: 04/Dec/15 2:49 PM

Resolved:: 04/Dec/15 2:49 PM

Fix Release Date:: 21/Dec/15