Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52332

core\plugininfo\calendartype::load_settings() has invalid declaration

    XMLWordPrintable

Details

    Description

      This cause unittest failure on php7. But also the declaration of the function is simply illegal and it would throw an exception if it was ever called. But it is not. Which is another bug.

      1) core_test_generator_testcase::test_create_module
      Declaration of core\plugininfo\calendartype::load_settings(core\plugininfo\part_of_admin_tree $adminroot, $parentnodename, $hassiteconfig) should be compatible with core\plugininfo\base::load_settings(part_of_admin_tree $adminroot, $parentnodename, $hassiteconfig)
       
      /Users/danp/moodles/im/moodle/lib/classes/plugininfo/calendartype.php:72
      /Users/danp/moodles/im/moodle/lib/classes/component.php:96
      /Users/danp/moodles/im/moodle/lib/classes/component.php:96
      /Users/danp/moodles/im/moodle/lib/classes/plugin_manager.php:476
      /Users/danp/moodles/im/moodle/lib/classes/plugin_manager.php:265
      /Users/danp/moodles/im/moodle/lib/classes/plugin_manager.php:286
      /Users/danp/moodles/im/moodle/availability/classes/tree.php:197
      /Users/danp/moodles/im/moodle/course/modlib.php:90
      /Users/danp/moodles/im/moodle/lib/testing/generator/module_generator.php:262
      /Users/danp/moodles/im/moodle/mod/assign/tests/generator/lib.php:59
      /Users/danp/moodles/im/moodle/lib/testing/generator/data_generator.php:480
      /Users/danp/moodles/im/moodle/lib/testing/tests/generator_test.php:295
      /Users/danp/moodles/im/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit core_test_generator_testcase lib/testing/tests/generator_test.php
      

      Attachments

        Issue Links

          Activity

            People

              marina Marina Glancy
              marina Marina Glancy
              Ryan Wyllie Ryan Wyllie
              Dan Poltawski Dan Poltawski
              Frédéric Massart Frédéric Massart
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                21/Dec/15