Loading...

XML

Word

Printable

Affected Branches:
MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
Fixed Branches:
MOODLE_29_STABLE, MOODLE_30_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Main Branch:
~~MDL-52342~~-master
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/compare/9d5d9c6...MDL-52342-master
Testing Instructions:
Hide

Open a course + turn editing on

Add an activity to a section and hide that section

Refresh the page

Confirm that there is no extra whitespace around the activity chooser link

There are some behat tests too which must be run against both Chrome + Firefox for the course/tests/behat/course_controls.feature feature - this tests the cause of the original regression.
Show
Open a course + turn editing on Add an activity to a section and hide that section Refresh the page Confirm that there is no extra whitespace around the activity chooser link There are some behat tests too which must be run against both Chrome + Firefox for the course/tests/behat/course_controls.feature feature - this tests the cause of the original regression.

and attached screenshots

please note that the margin is also added to the section name and activities names

is a regression caused by

MDL-42634 When a block/activity is hidden and editing is on the action menu is dimmed as well.

Participants:: Andrew Lyons, cameron1729, CiBoT, Dan Poltawski, David Monllaó, Marina Glancy, Mark Nelson, Rajesh Taneja