Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52342

Hiding section adds gaps to the activity chooser

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.9, 2.9.3, 3.0
    • Fix Version/s: 2.9.5, 3.0.3
    • Component/s: Course
    • Testing Instructions:
      Hide
      1. Open a course + turn editing on
      2. Add an activity to a section and hide that section
      3. Refresh the page
        • Confirm that there is no extra whitespace around the activity chooser link

      There are some behat tests too which must be run against both Chrome + Firefox for the course/tests/behat/course_controls.feature feature - this tests the cause of the original regression.

      Show
      Open a course + turn editing on Add an activity to a section and hide that section Refresh the page Confirm that there is no extra whitespace around the activity chooser link There are some behat tests too which must be run against both Chrome + Firefox for the course/tests/behat/course_controls.feature feature - this tests the cause of the original regression.
    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-52342-master
    • Pull Master Diff URL:
    • Sprint:
      3.1 Sprint 4
    • Issue size:
      Small

      Description

      See comment
      https://tracker.moodle.org/browse/MDL-42634?focusedCommentId=384094&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-384094

      and attached screenshots

      please note that the margin is also added to the section name and activities names

        Attachments

        1. activitymargin.png
          activitymargin.png
          22 kB
        2. firebug.png
          firebug.png
          141 kB
        3. hidden.png
          hidden.png
          22 kB
        4. visible.png
          visible.png
          22 kB

          Issue Links

          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-42634 When a block/activity is hidden and editing is on the action menu is dimmed as well.

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

            Activity

              People

              Assignee:
              dobedobedoh Andrew Lyons
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              cameron1729 cameron1729
              Integrator:
              Dan Poltawski Dan Poltawski
              Tester:
              Mark Nelson Mark Nelson
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Mar/16