Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52370

Course contacts cache should be purged when role is renamed

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.0, 3.1
    • Fix Version/s: 3.0.1
    • Component/s: Caching, Course
    • Labels:
    • Testing Instructions:
      Hide

      Site level changes:

      1. As admin
      2. In role settings, change the name of a role which is in course contacts
      3. View the course in course listings
      4. VERIFY: The name of the role displayed in course contacts matches the changed name immediately

      Course level changes:

      1. As teacher
      2. In course settings, change the name of a role which is in course contacts
      3. View the course in course listings
      4. VERIFY: The name of the role displayed in course contacts matches the changed name immediately
      Show
      Site level changes: As admin In role settings, change the name of a role which is in course contacts View the course in course listings VERIFY: The name of the role displayed in course contacts matches the changed name immediately Course level changes: As teacher In course settings, change the name of a role which is in course contacts View the course in course listings VERIFY: The name of the role displayed in course contacts matches the changed name immediately
    • Affected Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-52370-master
    • Pull Master Diff URL:

      Description

      Steps to reproduce:

      1. In course settings, change the name of a role
      2. View the course in course listings
      3. Examine the course contacts

      Expected results:

      • When user changes the name of a role it should be reflected in UI immediately

      Actual results:

      • Caching means the course contacts displays out of date info

      Analysis:
      Likely can be solved by calling coursecat::role_assignment_changed($ra->roleid, $context); when a role is renamed in the course form.

        Attachments

          Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-53010 fatal error when editing role

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          Discovered while testing

          Improvement - An enhancement to an existing Moodle feature. MDL-26935 New capability to control role renaming

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Improvement - An enhancement to an existing Moodle feature. MDL-41042 Course contacts shown in course listings can lag by up to an hour

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              poltawski Dan Poltawski
              Reporter:
              poltawski Dan Poltawski
              Peer reviewer:
              cameron1729
              Integrator:
              David Monllaó
              Tester:
              Ryan Wyllie
              Participants:
              Component watchers:
              Matteo Scaramuccia, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                21/Dec/15