[MDL-52420] Assignment comments should be also saved when clicking 'save changes' in the assignment grader page - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.7.11
Fix Version/s: 3.11
Component/s: Assignment, Comments
Labels:
- ci
- hqteam_alpha
- release_notes
- triaged

Affected Branches:
MOODLE_27_STABLE
Fixed Branches:
MOODLE_311_STABLE
Pull from Repository:
https://github.com/sharidas/moodle.git
Pull 3.11 Branch:
~~MDL-52420~~-311
Pull 3.11 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_311_STABLE...sharidas:MDL-52420-311
Pull Master Branch:
~~MDL-52420~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...sharidas:MDL-52420-master
Testing Instructions:
Hide

Below are the steps followed for testing this change set:

Using mdk created students, teachers and enrolled them in a new course

Create an assignment

Now navigate to grading page of the assignment created in step 2 by clicking "View all submissions" button.

For the student(s) listed in the grading page, click the Edit->Grade

Now click the comments link which will open up the comments (if any previous comments exist) and comment area.

Type a comment and click the "Save changes" button.

The newly added comment should be saved.

Type another comment and click the "Save and show next" button.

The newly added comment should be saved
Show
Below are the steps followed for testing this change set: Using mdk created students, teachers and enrolled them in a new course Create an assignment Now navigate to grading page of the assignment created in step 2 by clicking "View all submissions" button. For the student(s) listed in the grading page, click the Edit->Grade Now click the comments link which will open up the comments (if any previous comments exist) and comment area. Type a comment and click the "Save changes" button. The newly added comment should be saved . Type another comment and click the "Save and show next" button. The newly added comment should be saved

Story Points:
5
Sprint:
4.0 holding pattern 12

Description

Hello,

I could not find the same problem on the forum or similar ticket on Moodle tracker. But something does not react as it should be.

When a teacher add a commant on the grading page of the assignment (not quick grading), the comment is stored when clicking on save note, but not when clicking on save changes at the bottom of the page.

It is possible that this is normal, but I think the user must be asked to save the note before leaving the page when he or she clicks on save changes.

do you know what I understand and are you able to reproduce the problem?

Thanks in advance,

Best regards,

Mitchell van gerwen

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2021-02-10-13-23-10-831.png
27 kB
10/Feb/21 1:23 PM

Issue Links

has a non-specific relationship to

MDL-67542 Feedback comments lost when saving assignment grading guide and missing 1+ criterion score

Open

is duplicated by

MDL-59280 mod_assign: Save changes does not save comments

Closed

Activity

People

Assignee:: Sujith Haridasan

Reporter:: Mitchell van Gerwen

Peer reviewer:: Mihail Geshoski

Integrator:: Adrian Greeve

Tester:: Janelle Barcega

Participants:: Adrian Greeve, CiBoT, Damyon Wiese, Janelle Barcega, Mihail Geshoski, Mitchell van Gerwen, Sujith Haridasan

Component watchers:: Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 07/Dec/15 6:18 AM

Updated:: 07/May/21 6:15 PM

Resolved:: 11/Feb/21 10:35 PM

Fix Release Date:: 17/May/21

Time Tracking

Estimated:

Remaining:

Logged:

1d 4h 35m