Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-52487

RSS notices in php7 unit test execution

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0
    • Fix Version/s: 3.0.1
    • Component/s: RSS, Unit tests
    • Labels:

      Description

      As reported by Raj in MDL-50565:

      There are 2 notices in phpunit with current patch which are not being handled by "error Control Operators" in php7 (@)

      The notices are being generated by:

      1. blocks/rss_client/tests/cron_test.php
      2. lib/tests/rsslib_test.php

      Masking E_USER_NOTICE in test case fix the problem.

      -        @$block->cron();
      +        error_reporting($CFG->debug & ~E_USER_NOTICE);
      +        $block->cron();
      +        error_reporting($CFG->debug);
      

        Attachments

          Activity

            People

            • Assignee:
              dmonllao David Monllaó
              Reporter:
              poltawski Dan Poltawski
              Peer reviewer:
              Rajesh Taneja
              Integrator:
              Dan Poltawski
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                21/Dec/15